Bibo-Joshi · GitHub

Conversation

@Bibo-Joshi

Copy link Copy Markdown

Member

As discussed offline. We could maybe squash this into the commit of #2644

Checklist for PRs

  • Created new or adapted existing unit tests

Breaking changes:

  • Removed __dict__ from Disptacher slots

@Bibo-Joshi

harshil21

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine. We can also change these lines back to using normal assignment (i.e. _dp.__stop_event = ...)

harshil21

@Bibo-Joshi

@Bibo-Joshi

Closed

12 tasks

@harshil21 harshil21 changed the title Drop Dispatcher slots Drop __dict__ from Dispatcher slots

Jan 22, 2022

2 participants

@Bibo-Joshi @harshil21

Read the original on github.com ↗