Copy link Copy Markdown

Contributor

Added a filter Filters.update.edited working for both messages and channel posts.

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick PR! The new filter itself looks good :) However, we will need both documentation & tests for the new functionality (the PR template is there for a reason 😉 ). The documentation is just a few lines below your changes, you can add the new filter there. For the tests, please have a look at the file tests/test_filters.py and add a new test - you can copy & adapt the existing tests for Filters.update.*. The contribution guide also has a number of details on bulding the docs and running the tests ;)

Copy link Copy Markdown

Contributor Author

Thanks for the quick PR! The new filter itself looks good :) However, we will need both documentation & tests for the new functionality (the PR template is there for a reason 😉 ). The documentation is just a few lines below your changes, you can add the new filter there. For the tests, please have a look at the file tests/test_filters.py and add a new test - you can copy & adapt the existing tests for Filters.update.*. The contribution guide also has a number of details on bulding the docs and running the tests ;)

Thank you for the feedback, im on it 😃

Added `Filters.update.edited` to tests and documentation.

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂 I'll ask for a second review from the dev team and then we can merge

Copy link Copy Markdown

Member