Contributor
Checklist for PRs
- Added
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user-facing changes (for methods/class descriptions, arguments and attributes) - Created new or adapted existing unit tests
- Added myself alphabetically to
AUTHORS.rst(optional)
Closes #2627
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I left a comment.
Apart from that, please have a look at the failing tests - the error messages should tell you what can be improved. If you can't see the error messages due to access stuff, please leave a comment.
Also, the tests need to be adapted. They are located at tests/test_jobqueue.py. If you're having troubles with the unit tests or if you're new to pytest, feel free to ask for help :)
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I noticed that the docstring should be updated to state the changes. Please use the .. versionchanged:: directive (see here for an example) and explain in 2-3 sentences that
- the
day_is_strictargument was removed - instead one can pass
-1to thedayparameter to make the job run on the last day of the month.
Also update the docstring of the day parameter
