Poolitzer · GitHub

@Poolitzer

@Poolitzer Poolitzer commented

Aug 1, 2021

•

edited by Bibo-Joshi

Loading

Copy link Copy Markdown

Member

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Added myself alphabetically to AUTHORS.rst (optional)

closes #2333

Bibo-Joshi

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the overall structure 👍 Just added a few comments - IMHO we don't need to justify ourselfs in the contrib guide …

@Bibo-Joshi 

Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>

@Bibo-Joshi

@Bibo-Joshi

Read the original on github.com ↗