Bibo-Joshi · GitHub

@Bibo-Joshi

Copy link Copy Markdown

Member

First part of #2556

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)

github-actions[bot]

Copy link Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

@Bibo-Joshi

@Bibo-Joshi

Poolitzer

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes, only doc string suggestions

harshil21

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very good. Just one doubt.

# Conflicts:
#	telegram/ext/basepersistence.py

@Bibo-Joshi

@Bibo-Joshi

Read the original on github.com ↗