revolter ยท GitHub

@revolter

@revolter revolter commented

Jul 11, 2021

โ€ข

edited by Bibo-Joshi

Loading

Copy link Copy Markdown

Contributor

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Added myself alphabetically to AUTHORS.rst (optional)

If the PR contains API changes (otherwise, you can delete this passage)

  • New classes:

    • Added self._id_attrs and corresponding documentation
    • __init__ accepts **_kwargs
  • Added new shortcuts:

    • In Chat & User for all methods that accept chat/user_id
    • In Message for all methods that accept chat_id and message_id
    • For new Message shortcuts: Added quote argument if methods accepts reply_to_message_id
    • In CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id
  • If relevant:

    • Added new constants at telegram.constants and shortcuts to them as class variables
    • Added new handlers for new update types
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Updated the Bot API version number in all places: README.rst and README_RAW.rst (including the badge), as well as telegram.constants.BOT_API_VERSION
    • Added logic for arbitrary callback data in tg.ext.Bot for new methods that either accept a reply_markup in some form or have a return type that is/contains telegram.Message

closes #2580.

@Bibo-Joshi

Copy link Copy Markdown

Member

Hi. Sorry for getting back on this only now.
I made some more adjustments and think it should work out fine now. Would you mind testing for your use cases with the new changes?

@Bibo-Joshi

@revolter

Copy link Copy Markdown

Contributor Author

No problem. I tested it, and it works, though I don't understand the changes at all ๐Ÿ˜‚

@Bibo-Joshi

Copy link Copy Markdown

Member

๐Ÿ‘
They basicall try to make sure that the dispatcher uses the same class for the callbackcontext as the one you're calling right now. This is a bit more relevant as v13.6 introduced the possibility to use a custom subclass of CallbackContext.

@Bibo-Joshi

Closed

@revolter

revolter deleted the fix/callback-context-type-annotations branch

August 12, 2021 06:11

Read the original on github.com โ†—