Bibo-Joshi · GitHub

Conversation

@Bibo-Joshi

Copy link Copy Markdown

Member

  • Makes test_class_has_slots_and_dict use the correct relative path for our test setup, so it actually tests something :D
  • Handles windows
  • handles the __dict__ check for classes where __dict__ is in some parents __slots__, but we can't see that through MRO b/c of python magic (most notably for ABCs)

This caused some test failures in #1844 #2622 and I figured it's cleaner to just handles this in master directy …

@Bibo-Joshi

harshil21

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops my bad, looks fine.

@Bibo-Joshi

@Bibo-Joshi

sakibguy added a commit to sakibguy/python-telegram-bot that referenced this pull request

Jun 1, 2021

2 participants

@Bibo-Joshi @harshil21

Read the original on github.com ↗