Conversation
Member
Does three things:
- adds
ChatMemberUpdated.differenceas suggested by @harshil21 - the naming of the method is up for discussion, if you have other suggestions :) - Adds new constants to
tg.constants/Updatewhich can be used to setallowed_updatesmore conveniently - adds an example on how to use
ChatMemberHandlerand above stuff
pre-commit/pylint is failing locally for some reason. let's see how CI behaves.
Checklist for PRs
- Added
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes) - Created new or adapted existing unit tests
- Added myself alphabetically to
AUTHORS.rst(optional)
If the PR contains API changes (otherwise, you can delete this passage)
-
If relevant:
- Added new constants at
telegram.constantsand shortcuts to them as class variables - Added new handlers for new update types
- Added new filters for new message (sub)types
- Added or updated documentation for the changed class(es) and/or method(s)
- Updated the Bot API version number in all places:
README.rstandREADME_RAW.rst(including the badge), as well astelegram.constants.BOT_API_VERSION
- Added new constants at
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Found mostly spelling errors.
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good, I love the example and difference is a great idea.
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!