Member

• closes [BUG] Broken button '4' in inlinekeyboard2.py example #2440
• some typo fixes
• Handle empty inline queries without raising errors.
• remove unnecessary if condition in passportbot.py
• use ReplyKeyboardRemove() when conversation is over.
• use ForceReply in an example.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Member

@harshil21 since you are changing examples anyway, can you throw in a ForceReply somewhere? I think an example of that is good for people

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements! Left a comment. Also you mentioned:

• Handle empty inline queries without raising errors.

but I don't see that? If you want to add that, maybe an idea would be to use switch_pm_text to display a help message similarly to what rulesbot does. That feature is also little known.

Member Author

but I don't see that?

Oops, I guess I discarded those changes by mistake. It was if query == ""; return. The exception raised when it's empty is
Can't parse inline query result: input message content is not specified.

maybe an idea would be to use switch_pm_text to display a help message similarly to what rulesbot does.

So should I also put in switch_pm_{text, parameter}, along with the fix above?

Member

but I don't see that?

Oops, I guess I discarded those changes by mistake. It was if query == ""; return. The exception raised when it's empty is
Can't parse inline query result: input message content is not specified.

Jup, makes sense :)

maybe an idea would be to use switch_pm_text to display a help message similarly to what rulesbot does.

So should I also put in switch_pm_{text, parameter}, along with the fix above?

If you like to. Not important, just an idea ;)