Bibo-Joshi · GitHub

@Bibo-Joshi

Copy link Copy Markdown

Member

IISC that setting was just not changed when we started vendoring urllib3. see this thread for reference.

@Bibo-Joshi

@Bibo-Joshi

@tsnoam Telegram GithubBot Revised

Copy link Copy Markdown

Member

@Bibo-Joshi There's a culprit here:
We allow the library to be used without the vendored lib, so we need to know which urllib3 to change the default for.
OTOH, if someone is using a library we don't vendor maybe it's not our place to change the log level for that library.

@tsnoam Telegram GithubBot Revised

Copy link Copy Markdown

Member

@Bibo-Joshi

Copy link Copy Markdown

Member Author

OTOH, if someone is using a library we don't vendor maybe it's not our place to change the log level for that library.

I agree with, especially as this PR was triggered by someone actually having problems with us changing the log-level for the non-vendor version

Tests fail due to API update and the usual timeouts.

Merging.

@Bibo-Joshi

@Bibo-Joshi

Read the original on github.com ↗