github-actions · GitHub

Conversation

@Bibo-Joshi

Copy link Copy Markdown

Member

as discussed offline.

Adds requirements-extra called passport. Installing via pip install ptb[passport] seems more intuitive to me than installing as pip install ptb[crypto] and it's more flexible in terms of which optional dependencies are actually needed for passports.

superseeds #2377
closes #2372

github-actions[bot]

Copy link Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

yes, I did that ;)

github-actions[bot]

Copy link Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

Closed

… start to work

@Bibo-Joshi

Copy link Copy Markdown

Member Author

Upgrading pytest required a small workaround, see pytest-dev/pytest#8343. Documented with comments. Let's see if that did the trick.

@Bibo-Joshi

Copy link Copy Markdown

Member Author

Yeay, CI runs 🥳 Codecov is shy for some reason, but it looks good in the dashboard.

Bibo-Joshi added a commit that referenced this pull request

Feb 13, 2021

@Bibo-Joshi

@Bibo-Joshi

1 participant

@Bibo-Joshi

Read the original on github.com ↗