starry-shivam · GitHub

Mh, actually you're right about self.get_me() already setting self._bot, but imo it's still more readible to assign the return value anyway.

Some more notes:

  • Please document that bot is now comparable (See e.g. here) probably just do it als
    .. versionadded:: 13.2
       Objects of this class
  • After a closer look the tests fail b/c some tests want to monkeypatch bot.bot, which is no longer possible. Ig just making them patch bot._bot instead should be fine
  • Some other tests fail, b/c Bot is no longer hashable. Bot.__hash__ should return hash(self.bot), as that's what we're comparing with. see here
  • For what the equality tests should look like please see here

Read the original on github.com ↗