Conversation
Member
Stumbled accros that project it thought it's neat. TBH, I'm not 100% we should add it to the pre-commit as it's somewhat young (2017) and doesn't seem well recognized in terms of stars, forks and dependent packages (https://github.com/asottile/pyupgrade).
Then again, dependent packages don't list pre-commit iirc, and it's apparently rather actively maintained by the pre-commit author himself.
Also I didn't find an option to make it not change files in pre-commit (it fails, but automatically modifies the files).
Anyway, even if we don't add it, at least the changes it made seem valid :)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)
Member
I would vote in favour of implementing this, but since this is a dev dependency kind of, we should get votes from other maintainers I guess?
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright, looks good, just one comment
# Conflicts: # telegram/utils/helpers.py
Member Author
I'm gonna go ahead and merge. If we dislike it at some point, we can kick it, but we don't have to bee too strict on dev dependencies I guess …
2 participants
