Bibo-Joshi · GitHub

@Bibo-Joshi

Copy link Copy Markdown

Member

TBH I didn't try to send InputVenueMessageContent and ILQRVenue with both foursquare and google place details, but as that doesn't seem to work to send_venue, I assume it doesn't for those either …

@Bibo-Joshi

Closed

28 tasks

@Bibo-Joshi

Poolitzer

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one question, changes look great

Comment on lines -44 to -45

(For example, "arts_entertainment/default", "arts_entertainment/aquarium" or
"food/icecream".)

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I like this actually. Why did you remove it, maintaining?

Copy link Copy Markdown

Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because as a rule of thumb, attribute docstrings should be shorter than the corresponding argument docstring. at least that's what I did up to now …

@Bibo-Joshi

@Bibo-Joshi

Read the original on github.com ↗