Bibo-Joshi · GitHub

@harshil21

Copy link Copy Markdown

Member

All docs obtained from official Bot API docs.

All docs obtained from official Bot API docs

@harshil21

Copy link Copy Markdown

Member Author

There is also documentation related to API 4.7 in there

@Bibo-Joshi

Copy link Copy Markdown

Member

Wow, thanks! Will have to merge after #1858 though, if there is API 4.7 docs in there.
Also, flake8 is unhappy:

telegram/bot.py:506:100: E501 line too long (100 > 99 characters)

If you install the pre-commit hooks, git will check flake8 before commiting ;) see our contrib-guide

@harshil21

Copy link Copy Markdown

Member Author

Yea I didn't add all docs related to 4.7 since the new methods aren't there in bot.py yet.
Also I use GH desktop instead of git so that's why I can't run the tests before commiting :(

@harshil21

@Bibo-Joshi

Copy link Copy Markdown

Member

Yea I didn't add all docs related to 4.7 since the new methods aren't there in bot.py yet.

I guessed so ;) But we'll release the API 4.7 changes soon.

Also I use GH desktop instead of git so that's why I can't run the tests before commiting :(

You only need a command line. Non-GUI stuff was scary to me at first, too, but it's worth it :)

Bibo-Joshi

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a bit of nitpicking ;)
Please build the docs on your local machine to make sure that everything renders correctly. See the contrib-guide for details on that (you're gonna have to use the command line for that …)

@harshil21

Copy link Copy Markdown

Member Author

I did a bit of nitpicking ;)
Please build the docs on your local machine to make sure that everything renders correctly. See the contrib-guide for details on that (you're gonna have to use the command line for that …)

Yea I finally set up this command line thing and installed the pre-commit hooks. I'll now use it to render the docs too.

Also improved consistency of `returns:` in docs

@harshil21

Bibo-Joshi

@Bibo-Joshi

Copy link Copy Markdown

Member

CI fails unrelated (this is docs only). merging.

@Bibo-Joshi

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators

Aug 18, 2020

Read the original on github.com ↗