Copy link
Copy Markdown
Member
Originally intended to close #1671 , this now does 3 things:
- Unify the two methods of dispatcher used to update the persistence. This makes sure that
- If persistence is updated after handling an update, only the corresponding user/chat_data is updated
- Errors that appear when updating persistence on shutting down the bot will be handled correctly
- Fixing a minor bug in Pickle/DictPersistence: When calling
update_*_databefore callingget_*_data, we need to check that the internal attributes are notNone - Actually close [FEATURE] Persistence inside of Jobs #1671 by updating the persistence after running a job
Copy link
Copy Markdown
Member Author
CI:
- Py3.7 fails on
test_game_score. Unrelated Codecov mainly complains that the parts
'Saving user data raised an error and an ' \ 'uncaught error was raised while handling ' \ 'the error with an error_handler'
are not tested. But as far as I can see, they weren't tested before β¦
Added corresponding tests b/c more coverage = more better π€Έββ
Closed
Copy link
Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM