JosXa · GitHub

@JosXa

Copy link Copy Markdown

Contributor

Allows
url = helpers.create_deep_linked_url(bot.get_me().username, "Payload")

@jh0ker

Copy link Copy Markdown

Member

Looks good, but the example seems very convoluted. Do we really need 3 levels of deep linking to demonstrate how a single function works?

@JosXa

Copy link Copy Markdown

Contributor Author

@jh0ker It's more about explaining what's possible with deep links and to spark the imagination a bit

@jh0ker

Copy link Copy Markdown

Member

Fair enough, but in that case perhaps you could make one of the levels use an inline button with a URL instead of just another text link

@JosXa

Copy link Copy Markdown

Contributor Author

Good point

jsmnbom

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a nice utility to have to me :D
I added a few comments though :)

@tsnoam

Copy link Copy Markdown

Member

@JosXa
What is the status of this PR? ( @bomjacob requested certain changes)

@JosXa

Copy link Copy Markdown

Contributor Author

Currently not having the time to fix it up. Anyone else interested in getting the kudos for this contribution? @bomjacob

@Bibo-Joshi

Copy link Copy Markdown

Member

Brought this PR up to date and implemented the requested changes.
Also made it possible create startgroup deep linking urls using @JosXa s new helpers method

@tsnoam

@tsnoam

tsnoam deleted the deeplinking-tools branch

September 13, 2019 19:09

Read the original on github.com ↗