bdarnell · GitHub

Stopping and restarting a proactor event loop on windows can lead to
spurious errors logged (ConnectionResetError while reading from the
self pipe). This fixes the issue by ensuring that we don't attempt
to start multiple copies of the self-pipe reading loop.

@bdarnell

1st1

1st1 approved these changes Aug 31, 2020

@1st1

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Aug 31, 2020
Stopping and restarting a proactor event loop on windows can lead to
spurious errors logged (ConnectionResetError while reading from the
self pipe). This fixes the issue by ensuring that we don't attempt
to start multiple copies of the self-pipe reading loop.
(cherry picked from commit  ea5a636 )
Co-authored-by: Ben Darnell <ben@bendarnell.com>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Aug 31, 2020
Stopping and restarting a proactor event loop on windows can lead to
spurious errors logged (ConnectionResetError while reading from the
self pipe). This fixes the issue by ensuring that we don't attempt
to start multiple copies of the self-pipe reading loop.
(cherry picked from commit  ea5a636 )
Co-authored-by: Ben Darnell <ben@bendarnell.com>

Closed

bdarnell added a commit to bdarnell/cpython that referenced this pull request

Sep 2, 2020
Simply closing the event loop isn't enough to avoid warnings. If we
don't also shut down the event loop's default executor, it sometimes
logs a "dangling thread" warning.
Follow-up to pythonGH-22017

Merged

1st1 pushed a commit that referenced this pull request

Sep 3, 2020
Simply closing the event loop isn't enough to avoid warnings. If we
don't also shut down the event loop's default executor, it sometimes
logs a "dangling thread" warning.
Follow-up to GH-22017

1st1 pushed a commit that referenced this pull request

Sep 3, 2020
)
Stopping and restarting a proactor event loop on windows can lead to
spurious errors logged (ConnectionResetError while reading from the
self pipe). This fixes the issue by ensuring that we don't attempt
to start multiple copies of the self-pipe reading loop.
(cherry picked from commit  ea5a636 )
Co-authored-by: Ben Darnell <ben@bendarnell.com>
Co-authored-by: Ben Darnell <ben@bendarnell.com>

1st1 pushed a commit that referenced this pull request

Sep 3, 2020
)
Stopping and restarting a proactor event loop on windows can lead to
spurious errors logged (ConnectionResetError while reading from the
self pipe). This fixes the issue by ensuring that we don't attempt
to start multiple copies of the self-pipe reading loop.
(cherry picked from commit  ea5a636 )
Co-authored-by: Ben Darnell <ben@bendarnell.com>
Co-authored-by: Ben Darnell <ben@bendarnell.com>

Merged

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 3, 2020
Simply closing the event loop isn't enough to avoid warnings. If we
don't also shut down the event loop's default executor, it sometimes
logs a "dangling thread" warning.
Follow-up to pythonGH-22017
(cherry picked from commit  be435ae )
Co-authored-by: Ben Darnell <ben@bendarnell.com>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 3, 2020
Simply closing the event loop isn't enough to avoid warnings. If we
don't also shut down the event loop's default executor, it sometimes
logs a "dangling thread" warning.
Follow-up to pythonGH-22017
(cherry picked from commit  be435ae )
Co-authored-by: Ben Darnell <ben@bendarnell.com>

Merged

1st1 pushed a commit that referenced this pull request

Sep 3, 2020
Simply closing the event loop isn't enough to avoid warnings. If we
don't also shut down the event loop's default executor, it sometimes
logs a "dangling thread" warning.
Follow-up to GH-22017
(cherry picked from commit  be435ae )
Co-authored-by: Ben Darnell <ben@bendarnell.com>
Co-authored-by: Ben Darnell <ben@bendarnell.com>

1st1 pushed a commit that referenced this pull request

Sep 3, 2020

Read the original on github.com ↗