When having a closer look at the new Windows PGO Tailcall build logs
I've stumbled over
error : PGO run did not succeed (no python315!*.pgc files) and there is no data to merge
A closer look reveals that this happens on all Windows PGO builds in case of calling the Clean or CleanAll target. The culprit is here
| if "%do_pgo%"=="true" ( | |
| del /s "%dir%\*.pgc" | |
| del /s "%dir%\..\Lib\*.pyc" | |
| echo on | |
| call "%dir%\..\python.bat" %pgo_job% | |
| @echo off | |
| call :Kill | |
| set conf=PGUpdate | |
| set target=Build | |
| ) |
where
- the
pgo_jobis always invoked - and the target is always switched to
target=Build
in the PGUpdate phase.
I'll send a PR shortly.
cc @itamaro