Closed

vstinner changed the title ~~gh-132825: Change unhashable key error messages for dict and set~~ gh-132825: Enhance unhashable error messages for dict and set

Apr 23, 2025

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great thanks for working on this right away, Victor! As @methane pointed out, maybe Cannot -> cannot. We don't have a style guide or anything for exception messages, so maybe it doesn't matter either.

Copy link Copy Markdown

Member Author

maybe Cannot -> cannot

Done: I replaced "Cannot ..." with "cannot ...".

Copy link Copy Markdown

Thanks for this improvement! One minor nit: I like wordplays but I'm not sure if the T in unhashTable has been introduced on purpose?

Copy link Copy Markdown

Member Author

Thanks for this improvement! One minor nit: I like wordplays but I'm not sure if the T in unhashTable has been introduced on purpose?

It wasn't done on purpose, it's a typo :-( I wrote #132847 to fix the typo.

Open