Conversation
Copy link
Copy Markdown
Member
This is the final PR (apart from potential bug fixes) for #128682.
It:
- Handles
DECREF_INPUTSby either:- setting the on-stack references to
NULLbefore closing them, or - where more efficient, setting the stack pointer before each reference is closed
- setting the on-stack references to
- Changes many uses of
DECREF_INPUTStoPyStackRef_CLOSEwhere there was only one input. - Adds asserts that the stack pointer is spilled at key points outside of the interpreter.
Closed
markshannon deleted the account-for-escapes-in-decref-inputs branch
February 27, 2025 11:06
Copy link
Copy Markdown
Member
This change introduced a regression on opcodes using PyStackRef_AsPyObjectSteal() like CALL_LIST_APPEND: see issue gh-151818.
Labels
None yet