markshannon · GitHub

Conversation

@markshannon

Copy link Copy Markdown

Member

This is the final PR (apart from potential bug fixes) for #128682.
It:

  • Handles DECREF_INPUTS by either:
    • setting the on-stack references to NULL before closing them, or
    • where more efficient, setting the stack pointer before each reference is closed
  • Changes many uses of DECREF_INPUTS to PyStackRef_CLOSE where there was only one input.
  • Adds asserts that the stack pointer is spilled at key points outside of the interpreter.

Closed

@iritkatriel

Copy link Copy Markdown

Member

Some tests are failing.

@bedevere-bot

Copy link Copy Markdown

@markshannon

Copy link Copy Markdown

Member Author

iritkatriel

@markshannon

@markshannon

markshannon deleted the account-for-escapes-in-decref-inputs branch

February 27, 2025 11:06

@vstinner

Copy link Copy Markdown

Member

This change introduced a regression on opcodes using PyStackRef_AsPyObjectSteal() like CALL_LIST_APPEND: see issue gh-151818.

Labels

None yet

Read the original on github.com ↗