kooldev · GitHub

@beberlei

Copy link Copy Markdown

Contributor

kooldev

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same changes also need to be applied to @[] in #5928.

@beberlei

@beberlei

beberlei marked this pull request as ready for review

August 31, 2020 16:16

@nikic

Copy link Copy Markdown

Member

Tests for grouping?

@beberlei

@beberlei

Copy link Copy Markdown

Contributor Author

@nikic right, i have added some now in 028_grouped.phpt, rebased on master.

nikic

theodorejb

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to also test that grouping works for attributes without an argument list.

@beberlei

@beberlei

@beberlei

Copy link Copy Markdown

Contributor Author

Closed

Merged

Read the original on github.com ↗