carusogabriel · GitHub

@carusogabriel

Copy link Copy Markdown

Contributor

carusogabriel

Copy link Copy Markdown

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these this warnings right?

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carusogabriel carusogabriel changed the title Make compact function reports undefined passed variables [RFC] Make compact function reports undefined passed variables

May 25, 2018

@carusogabriel

@marcioAlmada

Copy link Copy Markdown

Contributor

I see there is a special branch for '$this' but do we have a test covering it? Anyway, a minor detail, voted yes!

@nikic

Copy link Copy Markdown

Member

@carusogabriel

Copy link Copy Markdown

Contributor Author

Should be RTM as the RFC was Accepted 😄

@php-pulls

Copy link Copy Markdown

Comment on behalf of cmb at php.net:

Thanks. Applied via fc775f6 .

@carusogabriel

@Majkl578

Copy link Copy Markdown

Contributor

@LC43

LC43 commented

Feb 18, 2019

•

edited

Loading

Copy link Copy Markdown

oops, thanks for the correction, @Majkl578! I'll remove my initial comment

Read the original on github.com ↗