Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ext/reflection looks okay
But maybe we should also add some tests so that future changes won't accidentally break things that are expected? E.g, based on the RFC

• confirm that it is unbacked
• confirm that there are only these two cases (e.g. the reflection output)

Member Author

accidentally

I don't see how changing the stub file can happen "by accident". The enum has no associated behavior, so any test would just be testing the stub generator.

Member

accidentally

I don't see how changing the stub file can happen "by accident". The enum has no associated behavior, so any test would just be testing the stub generator.

The "by accident" part would be that the stub file changes and the properties (not PHP properties, but in the sense of how things work) of the enum change without realizing that the current properties are based on an agreed-upon RFC. Just to have a second barrier to ensure that changes are intentional - not a big deal if you don't want to add the tests though