Member
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a quick look, have a few suggestions.
Open
Closed
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyone have an objection to making this ZEND_API?
Member Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no disagreement. I have chosen a lower visibility for the time being, as it is always easier to increase visibility afterwards instead of reducing it. But if you see a more global use case for the method, we can make it ZEND_API.
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've now merged this as-is. The PHPAPI can be added in a follow-up commit if necessary/desired.
Member
@joshuaruesweg The build on master was briefly broken, a rebase will fix CI here. Sorry for that.
Member
Now merged, thank you. Don't forget to adjust the RFC status to "Implemented" and to add the link to the implementation.
Closed
Merged
Merged
adrian-enspired pushed a commit to adrian-enspired/php-src that referenced this pull request
Aug 4, 2026