nikic · GitHub

Conversation

@pmmaga

Copy link Copy Markdown

Contributor

This PR is part of the Binary string deprecation RFC.

The PR for php-src can be found here

@Hywan

Copy link Copy Markdown

Contributor

Keep in mind that the RFC has not been voted yet. Must not merge this PR yet.

@Hywan

Copy link Copy Markdown

Contributor

And thanks for the PR :-).

@nikic

Copy link Copy Markdown

Member

As the actual removal will only happen in PHP 8, shouldn't this patch only specify deprecation?

@pmmaga

Copy link Copy Markdown

Contributor Author

Sure, I can change it to mention the deprecation on the text files then. About the test, should I keep it there as well then?

@pmmaga

@pmmaga

@pmmaga

Copy link Copy Markdown

Contributor Author

I've updated the PR to reflect the deprecation phase.

@pmmaga

Copy link Copy Markdown

Contributor Author

Closing as the RFC was rejected

@padrecedano

Copy link Copy Markdown

@pmmaga Do you know why this RFC was rejected? And, it can be deprecated in PHP 8? Thanks.

@pmmaga

Copy link Copy Markdown

Contributor Author

@padrecedano you can find the discussion here and more here The RFC itself is found here. Given the rejection, it is very unlikely it will get deprecated any time soon.

@padrecedano

Copy link Copy Markdown

@pmmaga thanks for the fast response and for the discussion links!

Read the original on github.com ↗