nimonian ยท GitHub

@nimonian

@nimonian

@nimonian

@coderabbitai

No actionable comments were generated in the recent review. ๐ŸŽ‰

โ„น๏ธ Recent review info โš™๏ธ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8fe57833-baf1-486d-8455-4c71b0dd6cf6

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 1a500f3 and 31525ad .

๐Ÿ“’ Files selected for processing (2)
  • src/runtime/components/prose/Img.vue
  • src/theme/prose/img.ts
๐Ÿšง Files skipped from review as they are similar to previous changes (2)
  • src/runtime/components/prose/Img.vue
  • src/theme/prose/img.ts

๐Ÿ“ Walkthrough

Walkthrough

The Prose image component and its theme were adjusted so the UI factory receives an explicit width flag (boolean) from the component props (!!props.width) along with existing zoom and open values. The theme's base slot class no longer includes w-full ('rounded-md w-full' โ†’ 'rounded-md'), and a new variants.width entry was added that applies w-full when width is false. No other template or exported API changes were made.

Estimated code review effort

๐ŸŽฏ 2 (Simple) | โฑ๏ธ ~10 minutes

๐Ÿšฅ Pre-merge checks | โœ… 5 โœ… Passed checks (5 passed)
Check name Status Explanation
Title check โœ… Passed The title accurately describes the main change: fixing the ProseImg component to respect markdown width attributes by conditionally applying w-full.
Description check โœ… Passed The description clearly explains the bug, its root cause, the masking conditions, and the proposed fix with verification evidence.
Linked Issues check โœ… Passed The PR fully addresses the requirement from #6349: making ProseImg conditionally apply w-full only when width is not set, allowing markdown width attributes to work.
Out of Scope Changes check โœ… Passed All changes are scoped to the ProseImg component and its theme configuration, directly addressing the width attribute override issue with no unrelated modifications.
Docstring Coverage โœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

โœ๏ธ Tip: You can configure your own custom pre-merge checks in the settings.

โœจ Finishing Touches ๐Ÿงช Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]

@vercel

benjamincanac

Co-authored-by: Benjamin Canac <canacb1@gmail.com>
Co-authored-by: Benjamin Canac <canacb1@gmail.com>

@vercel

benjamincanac

@benjamincanac

@nimonian

Read the original on github.com โ†—