KazimirPodolski ยท GitHub

๐Ÿ”— Linked issue

Resolves #5161

โ“ Type of change

  • ๐Ÿ“– Documentation (updates to the documentation or readme)
  • ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • ๐Ÿ‘Œ Enhancement (improving an existing functionality)
  • โœจ New feature (a non-breaking change that adds functionality)
  • ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description

Adds missing close prop to all Popover slots.

Popover uses either Reka Popover or Reka HoverCard depending on mode, and since HoverCard doesn't provide close, it will be undefined in mode="hover". I reflected it in documentation. Please tell if you want me to properly reflect in in the types too (probably should be done via a generic parameter inferring mode extends 'click' or something).

I did not touch tests as similar stuff in Modal is not tested, but I did check it locally in my project before commiting.

๐Ÿ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Read the original on github.com โ†—