Merged
Merged
Conversation
No actionable comments were generated in the recent review. ๐
โน๏ธ Recent review info โ๏ธ Run configurationConfiguration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2556eaa7-4a0f-4ea5-b272-d51eb45cd552
Reviewing files that changed from the base of the PR and between 0f2b9da and e4680db .
๐ Files selected for processing (1)src/runtime/types/tv.ts
๐ Walkthrough
Walkthrough
TVConfig<T> now conditionally types mapped theme properties: prose entries recursively use TVConfig<T[P]>, while other properties retain the existing object-shaped configuration, including compoundVariants.
Estimated code review effort: 1 (Trivial) | ~3 minutes
๐ฅ Pre-merge checks | โ 5 โ Passed checks (5 passed)| Check name | Status | Explanation |
|---|---|---|
| Title check | โ Passed | The title accurately summarizes the main change: fixing TypeScript typing for prose components in app config. |
| Description check | โ Passed | The description is directly related to the changeset and explains the prose typing fix in detail. |
| Docstring Coverage | โ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | โ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | โ Passed | Check skipped because no linked issues were found for this pull request. |
- Create stacked PR
- Commit on current branch
- Create PR with unit tests
- Commit unit tests in branch
fix/prose-app-config-types
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
โค๏ธ ShareComment @coderabbitai help to get the list of available commands.