Merged

Conversation

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info ⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3103b065-218b-477b-9041-6049d7d830c0

📥 Commits

Reviewing files that changed from the base of the PR and between 64b9f7d and 9bfcac4 .

📒 Files selected for processing (2)

src/runtime/composables/useFileUpload.ts
test/composables/useFileUpload.spec.ts

📝 Walkthrough

Walkthrough

The parseAcceptToDataTypes function in useFileUpload.ts was changed to always return a string array rather than possibly undefined, with empty or wildcard accept values now returning an empty array instead of undefined. The dataTypes computed value is now explicitly typed as computed<readonly string[]> and passed as a computed ref (rather than its unwrapped value) into useDropZone options. A new test file was added covering drop-zone file forwarding, file-dialog selection, dialog open behavior, drag state, accept-string parsing, dropzone disabling, and exposed refs.

Estimated code review effort: 2 (Simple) | ~12 minutes

🚥 Pre-merge checks | ✅ 5 ✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main fix: keeping the file upload dropzone filter reactive to accept changes.
Description check	✅ Passed	The description is directly related to the changeset and accurately explains the bug fix and added tests.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/file-upload-reactive-accept

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}