syazany ยท GitHub

Merged

Merged

Conversation

@syazany

@coderabbitai

Review Change Stack

๐Ÿ“ Walkthrough

Walkthrough

Link.vue now stores the localized path result and falls back to the original path when that value is falsy. A new Vitest suite mocks $localePath to return an empty string and verifies fallback href behavior for both Link.vue and Button.vue.

Estimated code review effort

๐ŸŽฏ 2 (Simple) | โฑ๏ธ ~10 minutes

๐Ÿšฅ Pre-merge checks | โœ… 4 | โŒ 1

โŒ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage โš ๏ธ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
โœ… Passed checks (4 passed)
Check name Status Explanation
Description check โœ… Passed The description matches the code changes and test additions for the localePath fallback regression.
Linked Issues check โœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check โœ… Passed Check skipped because no linked issues were found for this pull request.
Title check โœ… Passed The title clearly describes the main fix: falling back to the original path when localePath fails.
โœจ Finishing Touches ๐Ÿงช Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands.

@vercel

@benjamincanac benjamincanac changed the title fix(Link): fall back to original path when localePath fails fix(Link): fall back to original path when localePath fails

Jun 26, 2026

benjamincanac

@benjamincanac

@syazany

syazany deleted the fix/link-locale-path-fallback branch

June 27, 2026 05:56

This was referenced

Jul 5, 2026

Closed

Closed

Open

Read the original on github.com โ†—