Merged
Merged
Conversation
Walkthrough
Link.vue now stores the localized path result and falls back to the original path when that value is falsy. A new Vitest suite mocks $localePath to return an empty string and verifies fallback href behavior for both Link.vue and Button.vue.
Estimated code review effort
๐ฏ 2 (Simple) | โฑ๏ธ ~10 minutes
๐ฅ Pre-merge checks | โ 4 | โ 1โ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage | โ ๏ธ Warning | Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
| Check name | Status | Explanation |
|---|---|---|
| Description check | โ Passed | The description matches the code changes and test additions for the localePath fallback regression. |
| Linked Issues check | โ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | โ Passed | Check skipped because no linked issues were found for this pull request. |
| Title check | โ Passed | The title clearly describes the main fix: falling back to the original path when localePath fails. |
- Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
โค๏ธ ShareComment @coderabbitai help to get the list of available commands.
benjamincanac
changed the title
fix(Link): fall back to original path when localePath fails
fix(Link): fall back to original path when localePath fails
syazany deleted the fix/link-locale-path-fallback branch
June 27, 2026 05:56This was referenced
Jul 5, 2026Closed
Closed
Open