Merged
Merged
Conversation
Ready to act? Review this PR in Change Stack to turn feedback into patch suggestions you can inspect and refine.
๐ WalkthroughWalkthrough
This PR updates the Link component's prop defaults to explicitly set locale: undefined. Previously, the locale prop lacked an explicit default in withDefaults, causing downstream localization logic to not function correctly. The change ensures the locale prop is treated as unset when not provided, allowing the component's conditional locale-awareness logic (which checks props.locale === false and uses props.locale when calling $localePath) to operate as intended.
Estimated code review effort
๐ฏ 1 (Trivial) | โฑ๏ธ ~3 minutes
๐ฅ Pre-merge checks | โ 5 โ Passed checks (5 passed)| Check name | Status | Explanation |
|---|---|---|
| Description check | โ Passed | The description clearly explains the bug being fixed and references the linked issue, detailing why the explicit undefined default is necessary. |
| Linked Issues check | โ Passed | The PR directly addresses issue #6558 by fixing Vue's implicit boolean casting of the locale prop, enabling auto-localization by default as documented. |
| Out of Scope Changes check | โ Passed | The changes are narrowly scoped to the locale prop default in Link.vue and directly relate to resolving the linked issue requirement. |
| Docstring Coverage | โ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Title check | โ Passed | The title clearly and concisely describes the main change: setting a default value for the locale prop in the Link component to fix its localization behavior. |
โ๏ธ Tip: You can configure your own custom pre-merge checks in the settings.
โจ Finishing Touches ๐งช Generate unit tests (beta)- Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
โค๏ธ ShareComment @coderabbitai help to get the list of available commands and usage tips.
benjamincanac
changed the title
fix(link): set default for locale prop
fix(Link): set default for locale prop