Merged
Merged
Conversation
Walkthrough
This pull request expands the public prop surface of two search components—DashboardSearch and ContentSearch—to expose a wider set of CommandPalette configuration options. Previously, these components forwarded only a small subset of CommandPalette properties (icon, placeholder, autofocus, loading, loadingIcon, closeIcon, and groups). The changes update their type definitions and runtime prop forwarding to include additional fields for styling (trailingIcon, selectedIcon, childrenIcon), navigation (back, backIcon), interaction behavior (disabled, highlightOnHover), configuration (labelKey, descriptionKey, preserveGroupOrder), and rendering (virtualize).
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~8 minutes
🚥 Pre-merge checks | ✅ 5 ✅ Passed checks (5 passed)| Check name | Status | Explanation |
|---|---|---|
| Description check | ✅ Passed | The description clearly explains the bug (missing props being silently dropped) and the fix (adding all props to Pick<> type and forwarding them). |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Title check | ✅ Passed | The title accurately summarizes the main change: fixing the proxy of missing CommandPalette props in ContentSearch and DashboardSearch components. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches 📝 Generate docstrings- Create stacked PR
- Commit on current branch
- Create PR with unit tests
- Commit unit tests in branch
fix/search-proxy-command-palette-props
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ ShareComment @coderabbitai help to get the list of available commands and usage tips.
benjamincanac
changed the title
fix(ContentSearch,DashboardSearch): proxy missing CommandPalette props
fix(ContentSearch/DashboardSearch): proxy missing CommandPalette props