Conversation
Walkthrough
The FileUpload component now exposes a removeFile(index?: number) callback through its scoped slots. The FileUploadSlots type is updated to include removeFile on the files, file, and file-trailing slot prop objects. The component template is changed to pass remove-file into the files slot and into each per-file file and file-trailing slot so slot consumers can remove files via the provided callback.
Estimated code review effort
๐ฏ 2 (Simple) | โฑ๏ธ ~10 minutes
๐ฅ Pre-merge checks | โ 5 โ Passed checks (5 passed)| Check name | Status | Explanation |
|---|---|---|
| Description check | โ Passed | The description clearly explains the issue, the solution, provides a practical example, and links to the related issue #6491. |
| Linked Issues check | โ Passed | The PR fully addresses issue #6491 by exposing removeFile in the file and file-trailing slots, matching the objective to provide parity with other slots and enable custom file removal. |
| Out of Scope Changes check | โ Passed | All changes are directly related to the linked issue objective of exposing removeFile in file and file-trailing slots, with no out-of-scope modifications detected. |
| Docstring Coverage | โ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Title check | โ Passed | The title accurately describes the main change: exposing the removeFile function in file-related slots of the FileUpload component. |
โ๏ธ Tip: You can configure your own custom pre-merge checks in the settings.
โจ Finishing Touches ๐งช Generate unit tests (beta)- Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
โค๏ธ ShareComment @coderabbitai help to get the list of available commands and usage tips.
cydrickn
changed the title
fix(FileUpload): add removeFile to file and file trailing slots
feat(FileUpload): add removeFile to file and file trailing slots
benjamincanac
changed the title
feat(FileUpload): add removeFile to file and file trailing slots
feat(FileUpload): expose removeFile in slots