renovate · GitHub

@benjamincanac

@benjamincanac

@benjamincanac

@vercel

…ing it

@vercel

@sandros94

@vercel

@sandros94

@vercel

sandros94

@benjamincanac

@sandros94

@vercel

…ith other components

@coderabbitai

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info ⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6d386847-6c98-4a6f-8bed-5373791c7b7c

📥 Commits

Reviewing files that changed from the base of the PR and between c8ce2ae and 4e063dd .

📒 Files selected for processing (2)
  • test/components/Checkbox.spec.ts
  • test/components/Switch.spec.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • test/components/Checkbox.spec.ts

📝 Walkthrough

Walkthrough

The PR makes Checkbox and Switch generic (script setup generic="T = boolean"), adding typed modelValue, trueValue, and falseValue to props and emits (CheckboxProps<T>, CheckboxEmits<T>, SwitchProps<T>, SwitchEmits<T>). useForwardProps is replaced with useForwardPropsEmits and wired to forward the v-model-related props and emits. useFormField, defineProps, and defineEmits usages were updated to use generics. Components no longer bind v-model to their root; state is updated via emitted update:model-value/change events. Tests were updated and new tests added for custom true/false values.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 5 ✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main feature addition: support for trueValue and falseValue props on Checkbox and Switch components.
Description check ✅ Passed The description links to the relevant issue (#5821) and follow-up PR (#6147), providing context for the changes despite lacking implementation details.
Linked Issues check ✅ Passed The implementation adds generic type parameters and trueValue/falseValue props to both Checkbox and Switch components, meeting the core requirement to support custom true/false values like native checkboxes.
Out of Scope Changes check ✅ Passed All changes are scoped to implementing trueValue/falseValue support in Checkbox and Switch components with corresponding test coverage; no unrelated changes detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch pr/5821

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]

@vercel

@sandros94

@vercel

coderabbitai[bot]

…nd add tests

coderabbitai[bot]

@vercel

@benjamincanac

coderabbitai[bot]

…interaction tests

@vercel

@benjamincanac

@benjamincanac

Read the original on github.com ↗