testhound · GitHub

@testhound

Copy link Copy Markdown

Contributor

This pull request partially address issue: #6448 by adding support for retrieving the constant memory size utilized by a kernel from the Dispatcher.

… Dispatcher

@testhound

@testhound

Copy link Copy Markdown

Contributor Author

gpuci run tests

stuartarchibald

gmarkall

@testhound

@testhound

Copy link Copy Markdown

Contributor Author

gpuci run tests

@testhound

Copy link Copy Markdown

Contributor Author

@gmarkall I updated the docstring with you recommendation.

gmarkall

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the PR - there are some comments on the diff to address.

@testhound

Copy link Copy Markdown

Contributor Author

gpuci run tests

@testhound

Copy link Copy Markdown

Contributor Author

@gmarkall I updated the PR with all your comments and your patch.

gmarkall

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for resolving everything - this looks good now.

@esc / @stuartarchibald Could this have a CUDA buildfarm run please?

stuartarchibald

stuartarchibald

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. Approved for the purposes of testing on the build farm.

@stuartarchibald

Copy link Copy Markdown

Contributor

Buildfarm ID: numba_smoketest_cuda_yaml_149.

@stuartarchibald

Copy link Copy Markdown

Contributor

Buildfarm ID: numba_smoketest_cuda_yaml_149.

Passed.

Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>

@gmarkall

@gmarkall

Copy link Copy Markdown

Member

gpuci run tests

stuartarchibald

@sklam

Merged

Open

Read the original on github.com ↗