esc · GitHub

@esc

@esc esc commented

Jun 17, 2021

•

edited

Loading

Copy link Copy Markdown

Member 

As title
As title

@esc

@esc

Copy link Copy Markdown

Member Author

@esc

Copy link Copy Markdown

Member Author

@stuartarchibald

Copy link Copy Markdown

Contributor

stuartarchibald

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch.

@stuartarchibald

Copy link Copy Markdown

Contributor

Question... Does this create a minimum sphinx version requirement or is the patch backward compatible?

@esc

Copy link Copy Markdown

Member Author

Screen Shot 2021-06-17 at 18 20 28

Deprecated since 1.8, removed with 4.0 -- yes, new minimum sphinx is now 4.0

@stuartarchibald

Copy link Copy Markdown

Contributor

Screen Shot 2021-06-17 at 18 20 28

Deprecated since 1.8, removed with 4.0 -- yes, new minimum sphinx is now 4.0

Thanks, I guess we need to fix up the recipes and add a note in the docs too. Anything else?

@sklam

Closed

@esc esc mentioned this pull request

Jun 29, 2021

Merged

@esc

esc deleted the rtd/sphinx_compat branch

July 20, 2021 11:00

Open

Read the original on github.com ↗