Copy link
Copy Markdown
Contributor
As title.
As title.
Comment on lines +1302 to +1303
| *mod, fname = typing_key.split('.') | ||
| np_func = getattr(np.random, fname) |
Copy link
Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mod is unused and np.random is hardcode in getattr. Maybe there should be a assert to make sure mod is np.random
Copy link
Copy Markdown
Contributor Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As title. Responding to PR feedback.
Copy link
Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
