Closed
sam-github pushed a commit to sam-github/node that referenced this pull request
Nov 8, 2016Add support for fs.write(fd, buffer, cb) and fs.write(fd, buffer, offset, cb) as documented at https://nodejs.org/api/fs.html#fs_fs_write_fd_data_position_encoding_callback and equivalently for fs.writeSync Update docs and code comments to reflect the implementation. PR-URL: nodejs#7856 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Fishrock123 pushed a commit that referenced this pull request
Nov 22, 2016Add support for fs.write(fd, buffer, cb) and fs.write(fd, buffer, offset, cb) as documented at https://nodejs.org/api/fs.html#fs_fs_write_fd_data_position_encoding_callback and equivalently for fs.writeSync Update docs and code comments to reflect the implementation. PR-URL: #7856 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Closed
Closed
4 tasks
gibfahn
added
the
semver-minor
label
May 30, 2017Closed
MylesBorins pushed a commit that referenced this pull request
Oct 16, 2017Add support for fs.write(fd, buffer, cb) and fs.write(fd, buffer, offset, cb) as documented at https://nodejs.org/api/fs.html#fs_fs_write_fd_data_position_encoding_callback and equivalently for fs.writeSync Update docs and code comments to reflect the implementation. Backport-PR-URL: #13179 PR-URL: #7856 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
MylesBorins pushed a commit that referenced this pull request
Oct 25, 2017Add support for fs.write(fd, buffer, cb) and fs.write(fd, buffer, offset, cb) as documented at https://nodejs.org/api/fs.html#fs_fs_write_fd_data_position_encoding_callback and equivalently for fs.writeSync Update docs and code comments to reflect the implementation. Backport-PR-URL: #13179 PR-URL: #7856 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
MylesBorins added a commit that referenced this pull request
Nov 6, 2017Notable Changes:
* assert:
- assert.fail() can now take one or two arguments (Rich Trott)
#12293
* crypto:
- add sign/verify support for RSASSA-PSS (Tobias Nießen)
#11705
* deps:
- upgrade openssl sources to 1.0.2m (Shigeki Ohtsu)
#16691
- upgrade libuv to 1.15.0 (cjihrig)
#15745
- upgrade libuv to 1.14.1 (cjihrig)
#14866
- upgrade libuv to 1.13.1 (cjihrig)
#14117
- upgrade libuv to 1.12.0 (cjihrig)
#13306
* fs:
- Add support for fs.write/fs.writeSync(fd, buffer, cb) and
fs.write/fs.writeSync(fd, buffer, offset, cb) as documented
(Andreas Lind) #7856
* inspector:
- enable --inspect-brk (Refael Ackermann)
#12615
* process:
- add --redirect-warnings command line argument (James M Snell)
#10116
* src:
- allow CLI args in env with NODE_OPTIONS (Sam Roberts)
#12028)
- --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts)
#13932
- allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts)
#13172
- use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts)
#12677
* test:
- remove common.fail() (Rich Trott)
#12293
PR-URL: #16263
MylesBorins added a commit that referenced this pull request
Nov 7, 2017Notable Changes:
* assert:
- assert.fail() can now take one or two arguments (Rich Trott)
#12293
* crypto:
- add sign/verify support for RSASSA-PSS (Tobias Nießen)
#11705
* deps:
- upgrade openssl sources to 1.0.2m (Shigeki Ohtsu)
#16691
- upgrade libuv to 1.15.0 (cjihrig)
#15745
- upgrade libuv to 1.14.1 (cjihrig)
#14866
- upgrade libuv to 1.13.1 (cjihrig)
#14117
- upgrade libuv to 1.12.0 (cjihrig)
#13306
* fs:
- Add support for fs.write/fs.writeSync(fd, buffer, cb) and
fs.write/fs.writeSync(fd, buffer, offset, cb) as documented
(Andreas Lind) #7856
* inspector:
- enable --inspect-brk (Refael Ackermann)
#12615
* process:
- add --redirect-warnings command line argument (James M Snell)
#10116
* src:
- allow CLI args in env with NODE_OPTIONS (Sam Roberts)
#12028)
- --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts)
#13932
- allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts)
#13172
- use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts)
#12677
* test:
- remove common.fail() (Rich Trott)
#12293
PR-URL: #16263