trevnorris · GitHub

@trevnorris added buffer

Issues and PRs related to the buffer subsystem.

c++

Issues and PRs that require attention from people who are familiar with C++.

labels

Jun 2, 2016

@jasnell jasnell added the semver-major

PRs that contain breaking changes and should be released in the next major version.

label

Jun 2, 2016

@trevnorris

@jasnell jasnell added semver-minor

PRs that contain new features and should be released in the next minor version.

and removed semver-major

PRs that contain breaking changes and should be released in the next major version.

labels

Jun 6, 2016
When node began using the OneByte API ( f150d56 ) it also switched to
officially supporting ISO-8859-1. Though at the time no new encoding
string was introduced.
Introduce the new encoding string 'latin1' to be more explicit. The
previous 'binary' and documented as an alias to 'latin1'.  While many
tests have switched to use 'latin1', there are still plenty that do both
'binary' and 'latin1' checks side-by-side to ensure there is no
regression.
A message stuck around in the native API warning users to not use 'raw'
encoding. Followed by an abort(). This is no longer necessary since all
other signs of 'raw' encoding have been removed.

@trevnorris

@trevnorris

trevnorris added a commit to trevnorris/node that referenced this pull request

Jun 7, 2016
When node began using the OneByte API ( f150d56 ) it also switched to
officially supporting ISO-8859-1. Though at the time no new encoding
string was introduced.
Introduce the new encoding string 'latin1' to be more explicit. The
previous 'binary' and documented as an alias to 'latin1'.  While many
tests have switched to use 'latin1', there are still plenty that do both
'binary' and 'latin1' checks side-by-side to ensure there is no
regression.
PR-URL: nodejs#7111
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

trevnorris added a commit to trevnorris/node that referenced this pull request

Jun 7, 2016
A message stuck around in the native API warning users to not use 'raw'
encoding. Followed by an abort(). This is no longer necessary since all
other signs of 'raw' encoding have been removed.
PR-URL: nodejs#7111
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

This was referenced

Jun 15, 2016

Merged

Merged

@bnoordhuis bnoordhuis added semver-major

PRs that contain breaking changes and should be released in the next major version.

and removed semver-minor

PRs that contain new features and should be released in the next minor version.

labels

Jun 17, 2016

Closed

addaleax pushed a commit to addaleax/node that referenced this pull request

Aug 8, 2016
When node began using the OneByte API ( f150d56 ) it also switched to
officially supporting ISO-8859-1. Though at the time no new encoding
string was introduced.
Introduce the new encoding string 'latin1' to be more explicit. The
previous 'binary' and documented as an alias to 'latin1'.  While many
tests have switched to use 'latin1', there are still plenty that do both
'binary' and 'latin1' checks side-by-side to ensure there is no
regression.
PR-URL: nodejs#7111
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax pushed a commit to addaleax/node that referenced this pull request

Aug 8, 2016
A message stuck around in the native API warning users to not use 'raw'
encoding. Followed by an abort(). This is no longer necessary since all
other signs of 'raw' encoding have been removed.
PR-URL: nodejs#7111
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

Merged

Merged

Read the original on github.com ↗