nodejs-github-bot · GitHub

@nodejs-github-bot added lib / src

Issues and PRs related to general changes in the lib or src directory.

needs-ci

PRs that need a full CI run.

labels

Mar 6, 2026

@joyeecheung

Closed

hubot pushed a commit to v8/v8 that referenced this pull request

Mar 10, 2026
When the system does not have enough virtual memory for the wasm
cage, installing the trap handler would cause any code allocating
wasm memory to throw. Therefore it's useful for the embedder to
know when the system doesn't have enough virtual address space
to allocate enough wasm cages and in that case, skip the
trap handler installation so that wasm code can at least work
(even not at the maximal performance).
Node.js previously has a command line option
--disable-wasm-trap-handler to fully disable trap-based bound checks,
this new API would allow it to adapt automatically while keeping the
optimization in the happy path, since it's not always possible for
end users to opt-into disabling trap-based bound checks (for example,
when a VS Code Server is loaded in a remote server for debugging).
Refs: nodejs/node#62132
Refs: microsoft/vscode#251777
Change-Id: I345c076af2b2b47700e5716b49c3133fdf8a0981
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7638233
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105702}

@joyeecheung

@joyeecheung

@joyeecheung

@joyeecheung joyeecheung changed the title [WIP] src: do not enable wasm trap handler if there's not enough vmem src: do not enable wasm trap handler if there's not enough vmem

Mar 12, 2026

@joyeecheung joyeecheung added wasm

Issues and PRs related to WebAssembly.

memory

Issues and PRs related to the memory management or memory footprint.

lts-watch-v22.x

PRs that may need to be released in v22.x

lts-watch-v24.x

PRs that may need to be released in v24.x

labels

Mar 12, 2026

@joyeecheung

@joyeecheung

@sxa sxa mentioned this pull request

Mar 13, 2026

Open

10 tasks

Aditi-1400

RafaelGSS pushed a commit that referenced this pull request

Apr 27, 2026

RafaelGSS pushed a commit that referenced this pull request

Apr 28, 2026

SalimTerryLi added a commit to SalimTerryLi/openRuyi that referenced this pull request

May 27, 2026

SalimTerryLi added a commit to SalimTerryLi/openRuyi that referenced this pull request

May 27, 2026

SalimTerryLi added a commit to SalimTerryLi/openRuyi that referenced this pull request

May 27, 2026

SalimTerryLi added a commit to SalimTerryLi/openRuyi that referenced this pull request

May 27, 2026

SalimTerryLi added a commit to SalimTerryLi/openRuyi that referenced this pull request

May 27, 2026

SalimTerryLi added a commit to SalimTerryLi/openRuyi that referenced this pull request

May 27, 2026

SalimTerryLi added a commit to SalimTerryLi/openRuyi that referenced this pull request

May 27, 2026

SalimTerryLi added a commit to SalimTerryLi/openRuyi that referenced this pull request

May 27, 2026

SalimTerryLi added a commit to SalimTerryLi/openRuyi that referenced this pull request

Jun 3, 2026

SalimTerryLi added a commit to SalimTerryLi/openRuyi that referenced this pull request

Jun 5, 2026

joyeecheung added a commit to joyeecheung/node that referenced this pull request

Jul 7, 2026
Original commit message:
    [api] Add V8::GetWasmMemoryReservationSizeInBytes()
    When the system does not have enough virtual memory for the wasm
    cage, installing the trap handler would cause any code allocating
    wasm memory to throw. Therefore it's useful for the embedder to
    know when the system doesn't have enough virtual address space
    to allocate enough wasm cages and in that case, skip the
    trap handler installation so that wasm code can at least work
    (even not at the maximal performance).
    Node.js previously has a command line option
    --disable-wasm-trap-handler to fully disable trap-based bound checks,
    this new API would allow it to adapt automatically while keeping the
    optimization in the happy path, since it's not always possible for
    end users to opt-into disabling trap-based bound checks (for example,
    when a VS Code Server is loaded in a remote server for debugging).
    Refs: nodejs#62132
    Refs: microsoft/vscode#251777
    Change-Id: I345c076af2b2b47700e5716b49c3133fdf8a0981
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7638233
    Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Reviewed-by: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#105702}
Refs: v8/v8@ bef0d9c 
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: nodejs#62132
Refs: microsoft/vscode#251777
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7638233
Reviewed-By: Aditi Singh <aditisingh1400@gmail.com>
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

joyeecheung added a commit to joyeecheung/node that referenced this pull request

Jul 7, 2026

Closed

aduh95 pushed a commit that referenced this pull request

Jul 21, 2026
Original commit message:
    [api] Add V8::GetWasmMemoryReservationSizeInBytes()
    When the system does not have enough virtual memory for the wasm
    cage, installing the trap handler would cause any code allocating
    wasm memory to throw. Therefore it's useful for the embedder to
    know when the system doesn't have enough virtual address space
    to allocate enough wasm cages and in that case, skip the
    trap handler installation so that wasm code can at least work
    (even not at the maximal performance).
    Node.js previously has a command line option
    --disable-wasm-trap-handler to fully disable trap-based bound checks,
    this new API would allow it to adapt automatically while keeping the
    optimization in the happy path, since it's not always possible for
    end users to opt-into disabling trap-based bound checks (for example,
    when a VS Code Server is loaded in a remote server for debugging).
    Refs: #62132
    Refs: microsoft/vscode#251777
    Change-Id: I345c076af2b2b47700e5716b49c3133fdf8a0981
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7638233
    Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Reviewed-by: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#105702}
Refs: v8/v8@ bef0d9c 
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #62132
Backport-PR-URL: #64338
Refs: microsoft/vscode#251777
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7638233
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>

aduh95 pushed a commit that referenced this pull request

Jul 21, 2026

Merged

aduh95 pushed a commit that referenced this pull request

Jul 22, 2026
Original commit message:
    [api] Add V8::GetWasmMemoryReservationSizeInBytes()
    When the system does not have enough virtual memory for the wasm
    cage, installing the trap handler would cause any code allocating
    wasm memory to throw. Therefore it's useful for the embedder to
    know when the system doesn't have enough virtual address space
    to allocate enough wasm cages and in that case, skip the
    trap handler installation so that wasm code can at least work
    (even not at the maximal performance).
    Node.js previously has a command line option
    --disable-wasm-trap-handler to fully disable trap-based bound checks,
    this new API would allow it to adapt automatically while keeping the
    optimization in the happy path, since it's not always possible for
    end users to opt-into disabling trap-based bound checks (for example,
    when a VS Code Server is loaded in a remote server for debugging).
    Refs: #62132
    Refs: microsoft/vscode#251777
    Change-Id: I345c076af2b2b47700e5716b49c3133fdf8a0981
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7638233
    Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Reviewed-by: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#105702}
Refs: v8/v8@ bef0d9c 
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #62132
Backport-PR-URL: #64338
Refs: microsoft/vscode#251777
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7638233
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>

aduh95 pushed a commit that referenced this pull request

Jul 22, 2026

Read the original on github.com ↗