nodejs-github-bot · GitHub

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

config

Issues or PRs related to the config subsystem

needs-ci

PRs that need a full CI run.

labels

Mar 28, 2025

Closed

@danielmbrasil

@danielmbrasil danielmbrasil changed the title src: unflag --experimental-webstorage by default src,lib,test: unflag --experimental-webstorage by default

Apr 4, 2025

@danielmbrasil

@danielmbrasil

danielmbrasil

@danielmbrasil

geeksilva97

geeksilva97

mcollina

@danielmbrasil

geeksilva97

cjihrig

RafaelGSS added a commit that referenced this pull request

Oct 13, 2025
assert:
  * (SEMVER-MAJOR) move assert.fail with multiple arguments to eol (James M Snell) #58532
  * (SEMVER-MAJOR) move CallTracker to EOL (James M Snell) #58006
assert,util:
  * (SEMVER-MAJOR) fail promise comparison in deep equal checks (Ruben Bridgewater) #59448
  * (SEMVER-MAJOR) handle invalid dates as equal in deep comparison (Ruben Bridgewater) #57627
async_hooks:
  * (SEMVER-MAJOR) move `asyncResource` property on bound function to EOL (James M Snell) #58618
buffer:
  * (SEMVER-MAJOR) move SlowBuffer to EOL (Filip Skokan) #58220
build:
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #59805
  * (SEMVER-MAJOR) bump minimum Clang version to 19 (Michaël Zasso) #59048
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #58064
  * (SEMVER-MAJOR) stop distributing Corepack (Antoine du Hamel) #57617
child_process:
  * (SEMVER-MAJOR) move _channel to end-of-life (James M Snell) #58527
crypto:
  * (SEMVER-MAJOR) runtime-deprecate default shake128/256 output lengths (Filip Skokan) #59008
  * (SEMVER-MAJOR) move deprecated hash and mgf1Hash options to EOL (James M Snell) #58706
  * (SEMVER-MAJOR) runtime deprecate ECDH.setPublicKey() (James M Snell) #58620
deps:
  * (SEMVER-MAJOR) patch V8 for illumos (Dan McDonald) #59805
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077
  * (SEMVER-MAJOR) update V8 to 14.1.146.11 (Michaël Zasso) #59805
  * (SEMVER-MAJOR) V8: backport 1d3362c55396 (Shu-yu Guo) #58064
  * (SEMVER-MAJOR) V8: cherry-pick 4f38995c8295 (Shu-yu Guo) #58064
  * (SEMVER-MAJOR) V8: cherry-pick 044b9b6f589d (Rezvan Mahdavi Hezaveh) #58064
  * (SEMVER-MAJOR) V8: cherry-pick d2ad518a0b57 (Joyee Cheung) #58064
  * (SEMVER-MAJOR) V8: revert 6d6c1e680c7b (Michaël Zasso) #58064
  * (SEMVER-MAJOR) V8: revert e3cddbedb205 (Michaël Zasso) #58064
  * (SEMVER-MAJOR) use std::map in MSVC STL for EphemeronRememberedSet (Joyee Cheung) #58064
  * (SEMVER-MAJOR) patch V8 for illumos (Dan McDonald) #58064
  * (SEMVER-MAJOR) remove problematic comment from v8-internal (Michaël Zasso) #58064
  * (SEMVER-MAJOR) define V8_PRESERVE_MOST as no-op on Windows (Stefan Stojanovic) #58064
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #58064
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #58064
  * (SEMVER-MAJOR) update V8 to 13.7.152.9 (Michaël Zasso) #58064
dgram:
  * (SEMVER-MAJOR) move deprecated APIs to EOL (James M Snell) #58474
dns:
  * (SEMVER-MAJOR) move falsy hostname in lookup to end-of-life (James M Snell) #58619
doc,src,test:
  * (SEMVER-MAJOR) replace use of deprecated `GetIsolate` (Michaël Zasso) #59805
fs:
  * (SEMVER-MAJOR) move FileHandle close on GC to EOL (James M Snell) #58536
  * (SEMVER-MAJOR) move rmdir recursive option to end-of-life (James M Snell) #58616
  * (SEMVER-MAJOR) make `processReadResult()` and `readSyncRecursive()` private (Livia Medeiros) #58672
  * (SEMVER-MAJOR) move fs stream open method to eol (James M Snell) #58529
  * (SEMVER-MAJOR) remove `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #55862
http:
  * (SEMVER-MAJOR) deprecate writeHeader (Sebastian Beltran) #59060
lib:
  * (SEMVER-MAJOR) use validators for argument validation (Nam Yooseong) #59416
  * (SEMVER-MAJOR) expose global ErrorEvent (Richie Bendall) #58920
  * (SEMVER-MAJOR) deprecate `_stream_*` modules (Dario Piotrowicz) #58337
  * (SEMVER-MAJOR) deprecate _tls_common and _tls_wrap (Dario Piotrowicz) #57643
module:
  * (SEMVER-MAJOR) move Module._debug to end-of-life (James M Snell) #58473
node-api:
  * (SEMVER-MAJOR) add warning for NAPI_EXPERIMENTAL (Miguel Marcondes Filho) #58280
perf_hooks:
  * (SEMVER-MAJOR) move deprecated accessors to EOF (James M Snell) #58531
process:
  * (SEMVER-MAJOR) move multipleResolves event to EOL (James M Snell) #58707
repl:
  * (SEMVER-MAJOR) eol deprecate instantiating without new (Aviv Keller) #59495
src:
  * (SEMVER-MAJOR) update crypto.getCipherInfo() to use DictionaryTemplate (James M Snell) #60036
  * (SEMVER-MAJOR) fix calls to v8::Object::wrap (Andreas Haas) #59805
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 141 (Michaël Zasso) #59805
  * (SEMVER-MAJOR) improve performance of dotenv ToObject (James M Snell) #60038
  * (SEMVER-MAJOR) use std::string_view from node_report (iknoom) #60006
  * (SEMVER-MAJOR) unflag --experimental-webstorage by default (Daniel M Brasil) #57666
  * (SEMVER-MAJOR) store `Local` for `CallbackScope` on stack (Anna Henningsen) #59705
  * (SEMVER-MAJOR) remove node.h APIs to make callback without an async context (Chengzhong Wu) #58471
  * (SEMVER-MAJOR) remove deprecated node::EmitBeforeExit and node::EmitExit (Chengzhong Wu) #58469
  * (SEMVER-MAJOR) remove deprecated node::CreatePlatform and node::FreePlatform (Chengzhong Wu) #58470
  * (SEMVER-MAJOR) remove deprecated node::InitializeNodeWithArgs (Chengzhong Wu) #58470
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 138 (Michaël Zasso) #58064
src,permission:
  * (SEMVER-MAJOR) add --allow-net permission (Rafael Gonzaga) #58517
test:
  * (SEMVER-MAJOR) update cppgc-object addon config (StefanStojanovic) #59805
  * (SEMVER-MAJOR) spin longer for sequential/test-worker-prof (Michaël Zasso) #59805
  * (SEMVER-MAJOR) remove `--always-turbofan` flag (Michaël Zasso) #59805
  * (SEMVER-MAJOR) update snapshot for V8 14.1 (Michaël Zasso) #59805
test,win:
  * (SEMVER-MAJOR) split addon tests (StefanStojanovic) #59805
tls:
  * (SEMVER-MAJOR) move IP-address servername deprecation to eol (James M Snell) #58533
tools:
  * (SEMVER-MAJOR) update V8 gypfiles for 14.0 (Michaël Zasso) #59805
  * (SEMVER-MAJOR) update V8 gypfiles for 13.9 (Michaël Zasso) #59805
  * (SEMVER-MAJOR) update V8 gypfiles for 13.8 (Michaël Zasso) #59805
  * (SEMVER-MAJOR) enable leaptiering for aix/ibmi (Abdirahim Musse) #59805
  * (SEMVER-MAJOR) update V8 gypfiles for 13.7 (Michaël Zasso) #58064
url:
  * (SEMVER-MAJOR) move bad port deprecation in legacy url to end-of-life (James M Snell) #58617
util,console:
  * (SEMVER-MAJOR) colorize regexp groups, character classes, etc (Ruben Bridgewater) #59710
worker:
  * (SEMVER-MAJOR) move terminate callback to end-of-life (James M Snell) #58528
PR-URL: #59896
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>

RafaelGSS added a commit that referenced this pull request

Oct 15, 2025
assert:
  * (SEMVER-MAJOR) move assert.fail with multiple arguments to eol (James M Snell) #58532
  * (SEMVER-MAJOR) move CallTracker to EOL (James M Snell) #58006
assert,util:
  * (SEMVER-MAJOR) fail promise comparison in deep equal checks (Ruben Bridgewater) #59448
  * (SEMVER-MAJOR) handle invalid dates as equal in deep comparison (Ruben Bridgewater) #57627
async_hooks:
  * (SEMVER-MAJOR) move `asyncResource` property on bound function to EOL (James M Snell) #58618
buffer:
  * (SEMVER-MAJOR) move SlowBuffer to EOL (Filip Skokan) #58220
build:
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #59805
  * (SEMVER-MAJOR) bump minimum Clang version to 19 (Michaël Zasso) #59048
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #58064
  * (SEMVER-MAJOR) stop distributing Corepack (Antoine du Hamel) #57617
child_process:
  * (SEMVER-MAJOR) move _channel to end-of-life (James M Snell) #58527
crypto:
  * (SEMVER-MAJOR) runtime-deprecate default shake128/256 output lengths (Filip Skokan) #59008
  * (SEMVER-MAJOR) move deprecated hash and mgf1Hash options to EOL (James M Snell) #58706
  * (SEMVER-MAJOR) runtime deprecate ECDH.setPublicKey() (James M Snell) #58620
deps:
  * (SEMVER-MAJOR) patch V8 for illumos (Dan McDonald) #59805
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077
  * (SEMVER-MAJOR) update V8 to 14.1.146.11 (Michaël Zasso) #59805
  * (SEMVER-MAJOR) V8: backport 1d3362c55396 (Shu-yu Guo) #58064
  * (SEMVER-MAJOR) V8: cherry-pick 4f38995c8295 (Shu-yu Guo) #58064
  * (SEMVER-MAJOR) V8: cherry-pick 044b9b6f589d (Rezvan Mahdavi Hezaveh) #58064
  * (SEMVER-MAJOR) V8: cherry-pick d2ad518a0b57 (Joyee Cheung) #58064
  * (SEMVER-MAJOR) V8: revert 6d6c1e680c7b (Michaël Zasso) #58064
  * (SEMVER-MAJOR) V8: revert e3cddbedb205 (Michaël Zasso) #58064
  * (SEMVER-MAJOR) use std::map in MSVC STL for EphemeronRememberedSet (Joyee Cheung) #58064
  * (SEMVER-MAJOR) patch V8 for illumos (Dan McDonald) #58064
  * (SEMVER-MAJOR) remove problematic comment from v8-internal (Michaël Zasso) #58064
  * (SEMVER-MAJOR) define V8_PRESERVE_MOST as no-op on Windows (Stefan Stojanovic) #58064
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #58064
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #58064
  * (SEMVER-MAJOR) update V8 to 13.7.152.9 (Michaël Zasso) #58064
dgram:
  * (SEMVER-MAJOR) move deprecated APIs to EOL (James M Snell) #58474
dns:
  * (SEMVER-MAJOR) move falsy hostname in lookup to end-of-life (James M Snell) #58619
doc,src,test:
  * (SEMVER-MAJOR) replace use of deprecated `GetIsolate` (Michaël Zasso) #59805
fs:
  * (SEMVER-MAJOR) move FileHandle close on GC to EOL (James M Snell) #58536
  * (SEMVER-MAJOR) move rmdir recursive option to end-of-life (James M Snell) #58616
  * (SEMVER-MAJOR) make `processReadResult()` and `readSyncRecursive()` private (Livia Medeiros) #58672
  * (SEMVER-MAJOR) move fs stream open method to eol (James M Snell) #58529
  * (SEMVER-MAJOR) remove `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #55862
http:
  * (SEMVER-MAJOR) deprecate writeHeader (Sebastian Beltran) #59060
lib:
  * (SEMVER-MAJOR) use validators for argument validation (Nam Yooseong) #59416
  * (SEMVER-MAJOR) expose global ErrorEvent (Richie Bendall) #58920
  * (SEMVER-MAJOR) deprecate `_stream_*` modules (Dario Piotrowicz) #58337
  * (SEMVER-MAJOR) deprecate _tls_common and _tls_wrap (Dario Piotrowicz) #57643
module:
  * (SEMVER-MAJOR) move Module._debug to end-of-life (James M Snell) #58473
node-api:
  * (SEMVER-MAJOR) add warning for NAPI_EXPERIMENTAL (Miguel Marcondes Filho) #58280
perf_hooks:
  * (SEMVER-MAJOR) move deprecated accessors to EOF (James M Snell) #58531
process:
  * (SEMVER-MAJOR) move multipleResolves event to EOL (James M Snell) #58707
repl:
  * (SEMVER-MAJOR) eol deprecate instantiating without new (Aviv Keller) #59495
src:
  * (SEMVER-MAJOR) update crypto.getCipherInfo() to use DictionaryTemplate (James M Snell) #60036
  * (SEMVER-MAJOR) fix calls to v8::Object::wrap (Andreas Haas) #59805
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 141 (Michaël Zasso) #59805
  * (SEMVER-MAJOR) improve performance of dotenv ToObject (James M Snell) #60038
  * (SEMVER-MAJOR) use std::string_view from node_report (iknoom) #60006
  * (SEMVER-MAJOR) unflag --experimental-webstorage by default (Daniel M Brasil) #57666
  * (SEMVER-MAJOR) store `Local` for `CallbackScope` on stack (Anna Henningsen) #59705
  * (SEMVER-MAJOR) remove node.h APIs to make callback without an async context (Chengzhong Wu) #58471
  * (SEMVER-MAJOR) remove deprecated node::EmitBeforeExit and node::EmitExit (Chengzhong Wu) #58469
  * (SEMVER-MAJOR) remove deprecated node::CreatePlatform and node::FreePlatform (Chengzhong Wu) #58470
  * (SEMVER-MAJOR) remove deprecated node::InitializeNodeWithArgs (Chengzhong Wu) #58470
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 138 (Michaël Zasso) #58064
src,permission:
  * (SEMVER-MAJOR) add --allow-net permission (Rafael Gonzaga) #58517
test:
  * (SEMVER-MAJOR) update cppgc-object addon config (StefanStojanovic) #59805
  * (SEMVER-MAJOR) spin longer for sequential/test-worker-prof (Michaël Zasso) #59805
  * (SEMVER-MAJOR) remove `--always-turbofan` flag (Michaël Zasso) #59805
  * (SEMVER-MAJOR) update snapshot for V8 14.1 (Michaël Zasso) #59805
test,win:
  * (SEMVER-MAJOR) split addon tests (StefanStojanovic) #59805
tls:
  * (SEMVER-MAJOR) move IP-address servername deprecation to eol (James M Snell) #58533
tools:
  * (SEMVER-MAJOR) update V8 gypfiles for 14.0 (Michaël Zasso) #59805
  * (SEMVER-MAJOR) update V8 gypfiles for 13.9 (Michaël Zasso) #59805
  * (SEMVER-MAJOR) update V8 gypfiles for 13.8 (Michaël Zasso) #59805
  * (SEMVER-MAJOR) enable leaptiering for aix/ibmi (Abdirahim Musse) #59805
  * (SEMVER-MAJOR) update V8 gypfiles for 13.7 (Michaël Zasso) #58064
url:
  * (SEMVER-MAJOR) move bad port deprecation in legacy url to end-of-life (James M Snell) #58617
util,console:
  * (SEMVER-MAJOR) colorize regexp groups, character classes, etc (Ruben Bridgewater) #59710
worker:
  * (SEMVER-MAJOR) move terminate callback to end-of-life (James M Snell) #58528
PR-URL: #59896
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>

RafaelGSS added a commit that referenced this pull request

Oct 15, 2025
assert:
  * (SEMVER-MAJOR) move assert.fail with multiple arguments to eol (James M Snell) #58532
  * (SEMVER-MAJOR) move CallTracker to EOL (James M Snell) #58006
assert,util:
  * (SEMVER-MAJOR) fail promise comparison in deep equal checks (Ruben Bridgewater) #59448
  * (SEMVER-MAJOR) handle invalid dates as equal in deep comparison (Ruben Bridgewater) #57627
async_hooks:
  * (SEMVER-MAJOR) move `asyncResource` property on bound function to EOL (James M Snell) #58618
buffer:
  * (SEMVER-MAJOR) move SlowBuffer to EOL (Filip Skokan) #58220
build:
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #59805
  * (SEMVER-MAJOR) bump minimum Clang version to 19 (Michaël Zasso) #59048
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #58064
  * (SEMVER-MAJOR) stop distributing Corepack (Antoine du Hamel) #57617
child_process:
  * (SEMVER-MAJOR) move _channel to end-of-life (James M Snell) #58527
crypto:
  * (SEMVER-MAJOR) runtime-deprecate default shake128/256 output lengths (Filip Skokan) #59008
  * (SEMVER-MAJOR) move deprecated hash and mgf1Hash options to EOL (James M Snell) #58706
  * (SEMVER-MAJOR) runtime deprecate ECDH.setPublicKey() (James M Snell) #58620
deps:
  * (SEMVER-MAJOR) patch V8 for illumos (Dan McDonald) #59805
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077
  * (SEMVER-MAJOR) update V8 to 14.1.146.11 (Michaël Zasso) #59805
  * (SEMVER-MAJOR) V8: backport 1d3362c55396 (Shu-yu Guo) #58064
  * (SEMVER-MAJOR) V8: cherry-pick 4f38995c8295 (Shu-yu Guo) #58064
  * (SEMVER-MAJOR) V8: cherry-pick 044b9b6f589d (Rezvan Mahdavi Hezaveh) #58064
  * (SEMVER-MAJOR) V8: cherry-pick d2ad518a0b57 (Joyee Cheung) #58064
  * (SEMVER-MAJOR) V8: revert 6d6c1e680c7b (Michaël Zasso) #58064
  * (SEMVER-MAJOR) V8: revert e3cddbedb205 (Michaël Zasso) #58064
  * (SEMVER-MAJOR) use std::map in MSVC STL for EphemeronRememberedSet (Joyee Cheung) #58064
  * (SEMVER-MAJOR) patch V8 for illumos (Dan McDonald) #58064
  * (SEMVER-MAJOR) remove problematic comment from v8-internal (Michaël Zasso) #58064
  * (SEMVER-MAJOR) define V8_PRESERVE_MOST as no-op on Windows (Stefan Stojanovic) #58064
  * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #58064
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #58064
  * (SEMVER-MAJOR) update V8 to 13.7.152.9 (Michaël Zasso) #58064
dgram:
  * (SEMVER-MAJOR) move deprecated APIs to EOL (James M Snell) #58474
dns:
  * (SEMVER-MAJOR) move falsy hostname in lookup to end-of-life (James M Snell) #58619
doc,src,test:
  * (SEMVER-MAJOR) replace use of deprecated `GetIsolate` (Michaël Zasso) #59805
fs:
  * (SEMVER-MAJOR) move FileHandle close on GC to EOL (James M Snell) #58536
  * (SEMVER-MAJOR) move rmdir recursive option to end-of-life (James M Snell) #58616
  * (SEMVER-MAJOR) make `processReadResult()` and `readSyncRecursive()` private (Livia Medeiros) #58672
  * (SEMVER-MAJOR) move fs stream open method to eol (James M Snell) #58529
  * (SEMVER-MAJOR) remove `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #55862
http:
  * (SEMVER-MAJOR) deprecate writeHeader (Sebastian Beltran) #59060
lib:
  * (SEMVER-MAJOR) use validators for argument validation (Nam Yooseong) #59416
  * (SEMVER-MAJOR) expose global ErrorEvent (Richie Bendall) #58920
  * (SEMVER-MAJOR) deprecate `_stream_*` modules (Dario Piotrowicz) #58337
  * (SEMVER-MAJOR) deprecate _tls_common and _tls_wrap (Dario Piotrowicz) #57643
module:
  * (SEMVER-MAJOR) move Module._debug to end-of-life (James M Snell) #58473
node-api:
  * (SEMVER-MAJOR) add warning for NAPI_EXPERIMENTAL (Miguel Marcondes Filho) #58280
perf_hooks:
  * (SEMVER-MAJOR) move deprecated accessors to EOF (James M Snell) #58531
process:
  * (SEMVER-MAJOR) move multipleResolves event to EOL (James M Snell) #58707
repl:
  * (SEMVER-MAJOR) eol deprecate instantiating without new (Aviv Keller) #59495
src:
  * (SEMVER-MAJOR) update crypto.getCipherInfo() to use DictionaryTemplate (James M Snell) #60036
  * (SEMVER-MAJOR) fix calls to v8::Object::wrap (Andreas Haas) #59805
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 141 (Michaël Zasso) #59805
  * (SEMVER-MAJOR) improve performance of dotenv ToObject (James M Snell) #60038
  * (SEMVER-MAJOR) use std::string_view from node_report (iknoom) #60006
  * (SEMVER-MAJOR) unflag --experimental-webstorage by default (Daniel M Brasil) #57666
  * (SEMVER-MAJOR) store `Local` for `CallbackScope` on stack (Anna Henningsen) #59705
  * (SEMVER-MAJOR) remove node.h APIs to make callback without an async context (Chengzhong Wu) #58471
  * (SEMVER-MAJOR) remove deprecated node::EmitBeforeExit and node::EmitExit (Chengzhong Wu) #58469
  * (SEMVER-MAJOR) remove deprecated node::CreatePlatform and node::FreePlatform (Chengzhong Wu) #58470
  * (SEMVER-MAJOR) remove deprecated node::InitializeNodeWithArgs (Chengzhong Wu) #58470
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 138 (Michaël Zasso) #58064
src,permission:
  * (SEMVER-MAJOR) add --allow-net permission (Rafael Gonzaga) #58517
test:
  * (SEMVER-MAJOR) update cppgc-object addon config (StefanStojanovic) #59805
  * (SEMVER-MAJOR) spin longer for sequential/test-worker-prof (Michaël Zasso) #59805
  * (SEMVER-MAJOR) remove `--always-turbofan` flag (Michaël Zasso) #59805
  * (SEMVER-MAJOR) update snapshot for V8 14.1 (Michaël Zasso) #59805
test,win:
  * (SEMVER-MAJOR) split addon tests (StefanStojanovic) #59805
tls:
  * (SEMVER-MAJOR) move IP-address servername deprecation to eol (James M Snell) #58533
tools:
  * (SEMVER-MAJOR) update V8 gypfiles for 14.0 (Michaël Zasso) #59805
  * (SEMVER-MAJOR) update V8 gypfiles for 13.9 (Michaël Zasso) #59805
  * (SEMVER-MAJOR) update V8 gypfiles for 13.8 (Michaël Zasso) #59805
  * (SEMVER-MAJOR) enable leaptiering for aix/ibmi (Abdirahim Musse) #59805
  * (SEMVER-MAJOR) update V8 gypfiles for 13.7 (Michaël Zasso) #58064
url:
  * (SEMVER-MAJOR) move bad port deprecation in legacy url to end-of-life (James M Snell) #58617
util,console:
  * (SEMVER-MAJOR) colorize regexp groups, character classes, etc (Ruben Bridgewater) #59710
worker:
  * (SEMVER-MAJOR) move terminate callback to end-of-life (James M Snell) #58528
PR-URL: #59896
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>

This was referenced

Oct 17, 2025

Closed

Merged

Closed

rvagg added a commit to FilOzone/synapse-sdk that referenced this pull request

Oct 20, 2025
Node.js 25 became "current" and our CI is now testing it. We now have a failure
because "localStorage" is now a thing in Node.js but it's not properly
enabled without the arg. So @typescript/vfs, which in the browser detects
a "localStorage" and tries to use it (but previously in Node.js wouldn't find
it so wouldn't try) finds an implementation that's incomplete.
This change activates it, so we don't get the error. But we don't really need
it, so this can be wound back when we have a fix in vfs or somewhere else in
the stack.
Ref: nodejs/node#57666
Ref: microsoft/TypeScript-Website#3449
Ref: microsoft/TypeScript-Website#3450

@rvagg rvagg mentioned this pull request

Oct 20, 2025

Merged

rvagg added a commit to FilOzone/synapse-sdk that referenced this pull request

Oct 21, 2025
Node.js 25 became "current" and our CI is now testing it. We now have a failure
because "localStorage" is now a thing in Node.js but it's not properly
enabled without the arg. So @typescript/vfs, which in the browser detects
a "localStorage" and tries to use it (but previously in Node.js wouldn't find
it so wouldn't try) finds an implementation that's incomplete.
This change activates it, so we don't get the error. But we don't really need
it, so this can be wound back when we have a fix in vfs or somewhere else in
the stack.
Ref: nodejs/node#57666
Ref: microsoft/TypeScript-Website#3449
Ref: microsoft/TypeScript-Website#3450

Closed

6 tasks

Merged

deokjinkim added a commit to deokjinkim/node that referenced this pull request

Oct 22, 2025
For now, web storage is enabled by default.
Refs: nodejs#57666

Merged

nodejs-github-bot pushed a commit that referenced this pull request

Oct 24, 2025
For now, web storage is enabled by default.
Refs: #57666
PR-URL: #60363
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>

Merged

aduh95 pushed a commit that referenced this pull request

Oct 26, 2025
For now, web storage is enabled by default.
Refs: #57666
PR-URL: #60363
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>

Open

Merged

caixw added a commit to issue9/cmfx that referenced this pull request

Nov 18, 2025

lordshashank pushed a commit to lordshashank/synapse-sdk that referenced this pull request

Mar 9, 2026
…Ozone#329)
Node.js 25 became "current" and our CI is now testing it. We now have a failure
because "localStorage" is now a thing in Node.js but it's not properly
enabled without the arg. So @typescript/vfs, which in the browser detects
a "localStorage" and tries to use it (but previously in Node.js wouldn't find
it so wouldn't try) finds an implementation that's incomplete.
This change activates it, so we don't get the error. But we don't really need
it, so this can be wound back when we have a fix in vfs or somewhere else in
the stack.
Ref: nodejs/node#57666
Ref: microsoft/TypeScript-Website#3449
Ref: microsoft/TypeScript-Website#3450

Merged

5 tasks

Merged

7 tasks

Closed

3 tasks

@E-Lop E-Lop mentioned this pull request

Jun 16, 2026

Merged

Merged

Merged

zioalex pushed a commit to zioalex/getinspiredbythebible that referenced this pull request

Jul 27, 2026
…rkers
The Node 26.x leg added in the previous commit failed CI: Node >=25
enables a native `localStorage` global by default (nodejs/node#57666),
which throws a DOMException without --localstorage-file and shadows
jsdom's own window.localStorage before vitest-environment-jsdom can
install it. Every test touching localStorage saw it as undefined
(WhatsNewModal.test.tsx, page.test.tsx's BITB-029 case), while 22.x
was unaffected since the global is opt-in-only before Node 25.
Pass --no-experimental-webstorage to vitest's worker processes via
the now-flat `execArgv` option (Vitest 4 removed the old
`poolOptions.threads/forks.execArgv` nesting) so jsdom's localStorage
wins again. Verified 773/773 unit tests, lint, and type-check pass
locally with the flag applied; confirmed via Node's own changelog
that the flag was introduced alongside --experimental-webstorage in
v22.4.0, so it's a recognized no-op on the 22.x leg too.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NQfpC1H5MQRgQWuTfyWSMp

This was referenced

Aug 3, 2026

Closed

Merged

Merged

7 tasks

Read the original on github.com ↗