added the semver-minor

PRs that contain new features and should be released in the next minor version.

label

Mar 2, 2025

nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

crypto

Issues and PRs related to the crypto subsystem.

needs-ci

PRs that need a full CI run.

labels

Mar 2, 2025

panva changed the title ~~crypto: add optional callback to crypto.diffiehellman~~ crypto: add optional callback to crypto.diffieHellman

Mar 2, 2025

panva marked this pull request as ready for review

March 2, 2025 16:02

panva added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

and removed author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

labels

Mar 2, 2025

panva added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

request-ci

Add this label to start a Jenkins CI on a PR.

labels

Mar 14, 2025

panva added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

Mar 15, 2025

panva deleted the diffiehellman-callback branch

March 15, 2025 10:45

aduh95 pushed a commit that referenced this pull request

Mar 18, 2025

PR-URL: #57274
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Merged

aduh95 added a commit that referenced this pull request

Mar 30, 2025

Notable changes:
assert:
  * (SEMVER-MINOR) implement partial error comparison (Ruben Bridgewater) #57370
crypto:
  * (SEMVER-MINOR) add optional callback to `crypto.diffieHellman` (Filip Skokan) #57274
process:
  * (SEMVER-MINOR) add `execve` (Paolo Insogna) #56496
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.columns()` (Colin Ihrig) #57490
util:
  * (SEMVER-MINOR) expose diff function used by the assertion errors (Giovanni Bucci) #57462
PR-URL: #57694
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

aduh95 added a commit that referenced this pull request

Apr 1, 2025

Notable changes:
assert:
  * (SEMVER-MINOR) implement partial error comparison (Ruben Bridgewater) #57370
crypto:
  * (SEMVER-MINOR) add optional callback to `crypto.diffieHellman` (Filip Skokan) #57274
process:
  * (SEMVER-MINOR) add `execve` (Paolo Insogna) #56496
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.columns()` (Colin Ihrig) #57490
util:
  * (SEMVER-MINOR) expose diff function used by the assertion errors (Giovanni Bucci) #57462
PR-URL: #57694

aduh95 added a commit that referenced this pull request

Apr 1, 2025

Notable changes:
assert:
  * (SEMVER-MINOR) implement partial error comparison (Ruben Bridgewater) #57370
crypto:
  * (SEMVER-MINOR) add optional callback to `crypto.diffieHellman` (Filip Skokan) #57274
process:
  * (SEMVER-MINOR) add `execve` (Paolo Insogna) #56496
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.columns()` (Colin Ihrig) #57490
util:
  * (SEMVER-MINOR) expose diff function used by the assertion errors (Giovanni Bucci) #57462
PR-URL: #57694

RafaelGSS pushed a commit that referenced this pull request

Apr 1, 2025

PR-URL: #57274
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Closed

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request

Apr 20, 2025

RafaelGSS pushed a commit that referenced this pull request

May 1, 2025

PR-URL: #57274
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

RafaelGSS pushed a commit that referenced this pull request

May 1, 2025

Notable changes:
assert:
  * (SEMVER-MINOR) implement partial error comparison (Ruben Bridgewater) #57370
crypto:
  * (SEMVER-MINOR) add optional callback to `crypto.diffieHellman` (Filip Skokan) #57274
process:
  * (SEMVER-MINOR) add `execve` (Paolo Insogna) #56496
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.columns()` (Colin Ihrig) #57490
util:
  * (SEMVER-MINOR) expose diff function used by the assertion errors (Giovanni Bucci) #57462
PR-URL: #57694

RafaelGSS pushed a commit that referenced this pull request

May 2, 2025

PR-URL: #57274
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

RafaelGSS pushed a commit that referenced this pull request

May 2, 2025

Notable changes:
assert:
  * (SEMVER-MINOR) implement partial error comparison (Ruben Bridgewater) #57370
crypto:
  * (SEMVER-MINOR) add optional callback to `crypto.diffieHellman` (Filip Skokan) #57274
process:
  * (SEMVER-MINOR) add `execve` (Paolo Insogna) #56496
sqlite:
  * (SEMVER-MINOR) add `StatementSync.prototype.columns()` (Colin Ihrig) #57490
util:
  * (SEMVER-MINOR) expose diff function used by the assertion errors (Giovanni Bucci) #57462
PR-URL: #57694