nodejs-github-bot · GitHub

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

needs-ci

PRs that need a full CI run.

labels

Mar 15, 2024

nicolo-ribaudo

This patch removes support for the `assert` keyword
for import attributes. It was an old variant of the
proposal that was only shipped in V8 and no other
engine, and that has then been replaced by the `with`
keyword.
Chrome is planning to remove support for `assert`
in version 126, which will be released in June.
Node.js already supports the `with` keyword for
import attributes, and this patch does not change that.

@nicolo-ribaudo

mcollina

Merged

joyeecheung

Closed

4 tasks

Closed

Closed

1 task

Closed

Merged

nodejs-github-bot pushed a commit that referenced this pull request

Nov 18, 2024
PR-URL: #55883
Refs: #52104
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

Closed

aduh95 added a commit that referenced this pull request

Nov 26, 2024
PR-URL: #55883
Refs: #52104
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

Closed

4 tasks

Merged

aduh95 added a commit that referenced this pull request

Dec 10, 2024
PR-URL: #55883
Refs: #52104
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

Merged

buzz added a commit to buzz/imdb-link-em-all that referenced this pull request

Dec 17, 2024

ruyadorno pushed a commit that referenced this pull request

Jan 5, 2025
PR-URL: #55883
Refs: #52104
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

Open

Merged

@jpmcb jpmcb mentioned this pull request

May 2, 2025

Merged

@eucyt eucyt mentioned this pull request

May 7, 2025

Closed

Merged

Merged

Closed

Merged

4 tasks

Merged

Merged

This was referenced

Aug 8, 2026

Open

Open

Open

Closed

Read the original on github.com ↗