nodejs-github-bot · GitHub

anonrig

@ErickWendel

@ErickWendel ErickWendel changed the title test: fix mock.method to suport class instances test: fix mock.method to support class instances

Nov 24, 2022

@aduh95 aduh95 changed the title test: fix mock.method to support class instances test_runner: fix mock.method to support class instances

Nov 24, 2022

aduh95

ljharb

cjihrig

@ErickWendel

aduh95

cjihrig

It fixes a problem when trying to spy a method
from a class instance or static functions
on a class instance
Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
Signed-off-by: Erick Wendel <erick.workspace@gmail.com>

ljharb

benjamingr

Open

13 tasks

@aduh95 aduh95 added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

Dec 17, 2022

@cjihrig cjihrig added commit-queue

Add this label to land a pull request using GitHub Actions.

commit-queue-squash

Add this label to instruct the Commit Queue to squash all the PR commits into the first one.

and removed commit-queue-failed

An error occurred while landing this pull request using GitHub Actions.

labels

Dec 17, 2022

@nodejs-github-bot

This was referenced

Dec 18, 2022

Open

Open

Open

targos pushed a commit that referenced this pull request

Jan 1, 2023
It fixes a problem when trying to spy a method
from a class instance or static functions
on a class instance
PR-URL: #45608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Merged

@MoLow MoLow mentioned this pull request

Jan 26, 2023

Closed

juanarbol pushed a commit that referenced this pull request

Jan 26, 2023
It fixes a problem when trying to spy a method
from a class instance or static functions
on a class instance
PR-URL: #45608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Merged

MoLow pushed a commit to MoLow/node-core-test that referenced this pull request

Feb 2, 2023
It fixes a problem when trying to spy a method
from a class instance or static functions
on a class instance
PR-URL: nodejs/node#45608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
(cherry picked from commit 929aada39d0f418193ca03cc360ced8c5b4ce553)

Read the original on github.com ↗