added fs

Issues and PRs related to the fs subsystem / file system.

needs-ci

PRs that need a full CI run.

labels

Sep 6, 2021

aduh95 added the semver-minor

PRs that contain new features and should be released in the next minor version.

label

Sep 6, 2021

aduh95 added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

request-ci

Add this label to start a Jenkins CI on a PR.

labels

Sep 8, 2021

This was referenced

Sep 14, 2021

Open

aduh95 added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

Sep 16, 2021

When using `createReadStream` or `createWriteStream` with a specific
file descriptor or `FileHandle` instead of a path, `open` method is not
used, there is no point in forcing users to provide it.
When using `createReadStream` or `createWriteStream` with  `autoClose`
set to false, `close` method is not used, there is no point in forcing
users to provide it.
PR-URL: nodejs#40013
Reviewed-By: James M Snell <jasnell@gmail.com>

aduh95 deleted the fs-streams-optional-open-close branch

September 16, 2021 22:47

This was referenced

Sep 17, 2021

Open

BethGriggs pushed a commit that referenced this pull request

Sep 21, 2021

When using `createReadStream` or `createWriteStream` with a specific
file descriptor or `FileHandle` instead of a path, `open` method is not
used, there is no point in forcing users to provide it.
When using `createReadStream` or `createWriteStream` with  `autoClose`
set to false, `close` method is not used, there is no point in forcing
users to provide it.
PR-URL: #40013
Reviewed-By: James M Snell <jasnell@gmail.com>

BethGriggs added a commit that referenced this pull request

Sep 21, 2021

Notable changes:
crypto:
  * (SEMVER-MINOR) add rsa-pss keygen parameters (Filip Skokan) #39927
doc:
  * add Ayase-252 to collaborators (Qingyu Deng) #40078
fs:
  * (SEMVER-MINOR) make `open` and `close` stream override optional when unused (Antoine du Hamel) #40013
http:
  * (SEMVER-MINOR) limit requests per connection (Artur K) #40082
src:
  * (SEMVER-MINOR) add --no-global-search-paths cli option (Cheng Zhao) #39754
  * (SEMVER-MINOR) add option to disable global search paths (Cheng Zhao) #39754
  * (SEMVER-MINOR) make napi_create_reference accept symbol (JckXia) #39926
stream:
  * (SEMVER-MINOR) add signal support to pipeline generators (Robert Nagy) #39067
PR-URL: TODO

BethGriggs pushed a commit that referenced this pull request

Sep 21, 2021

When using `createReadStream` or `createWriteStream` with a specific
file descriptor or `FileHandle` instead of a path, `open` method is not
used, there is no point in forcing users to provide it.
When using `createReadStream` or `createWriteStream` with  `autoClose`
set to false, `close` method is not used, there is no point in forcing
users to provide it.
PR-URL: #40013
Reviewed-By: James M Snell <jasnell@gmail.com>

BethGriggs added a commit that referenced this pull request

Sep 21, 2021

Notable changes:
crypto:
  * (SEMVER-MINOR) add rsa-pss keygen parameters (Filip Skokan) #39927
doc:
  * add Ayase-252 to collaborators (Qingyu Deng) #40078
fs:
  * (SEMVER-MINOR) make `open` and `close` stream override optional when unused (Antoine du Hamel) #40013
http:
  * (SEMVER-MINOR) limit requests per connection (Artur K) #40082
src:
  * (SEMVER-MINOR) add --no-global-search-paths cli option (Cheng Zhao) #39754
  * (SEMVER-MINOR) add option to disable global search paths (Cheng Zhao) #39754
  * (SEMVER-MINOR) make napi_create_reference accept symbol (JckXia) #39926
stream:
  * (SEMVER-MINOR) add signal support to pipeline generators (Robert Nagy) #39067
PR-URL: TODO

Merged

1 task

Open

15 tasks

BethGriggs added a commit that referenced this pull request

Sep 22, 2021

Notable changes:
crypto:
  * (SEMVER-MINOR) add rsa-pss keygen parameters (Filip Skokan) #39927
doc:
  * add Ayase-252 to collaborators (Qingyu Deng) #40078
fs:
  * (SEMVER-MINOR) make `open` and `close` stream override optional when unused (Antoine du Hamel) #40013
http:
  * (SEMVER-MINOR) limit requests per connection (Artur K) #40082
src:
  * (SEMVER-MINOR) add --no-global-search-paths cli option (Cheng Zhao) #39754
  * (SEMVER-MINOR) add option to disable global search paths (Cheng Zhao) #39754
  * (SEMVER-MINOR) make napi_create_reference accept symbol (JckXia) #39926
stream:
  * (SEMVER-MINOR) add signal support to pipeline generators (Robert Nagy) #39067
PR-URL: #40175

BethGriggs added a commit that referenced this pull request

Sep 22, 2021

Notable changes:
crypto:
  * (SEMVER-MINOR) add rsa-pss keygen parameters (Filip Skokan) #39927
doc:
  * add Ayase-252 to collaborators (Qingyu Deng) #40078
fs:
  * (SEMVER-MINOR) make `open` and `close` stream override optional when unused (Antoine du Hamel) #40013
http:
  * (SEMVER-MINOR) limit requests per connection (Artur K) #40082
src:
  * (SEMVER-MINOR) add --no-global-search-paths cli option (Cheng Zhao) #39754
  * (SEMVER-MINOR) add option to disable global search paths (Cheng Zhao) #39754
  * (SEMVER-MINOR) make napi_create_reference accept symbol (JckXia) #39926
stream:
  * (SEMVER-MINOR) add signal support to pipeline generators (Robert Nagy) #39067
PR-URL: #40175

ylemkimon added a commit to ylemkimon/node that referenced this pull request

Sep 29, 2021

nodejs#40013 changed the behavior of `readStream.path`, it'll be `undefined` if `fd` is specified.

Closed

Ayase-252 pushed a commit that referenced this pull request

Oct 7, 2021

it'll be `undefined` if `fd` is specified.
Refs: #40013
PR-URL: #40252
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

danielleadams pushed a commit to danielleadams/node that referenced this pull request

Oct 8, 2021

it'll be `undefined` if `fd` is specified.
Refs: nodejs#40013
PR-URL: nodejs#40252
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>