added http

Issues or PRs related to the http subsystem.

Issues or PRs related to the http2 subsystem.

labels

Apr 30, 2020

rexagod changed the title ~~http2: add checks for Http2Server.Response.write~~ http2: add type checks for Http2Server.Response.write

May 1, 2020

dont throw errors on Uint8Arrays and added test for all
valid types
Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
fixup: remove dup
fixup: remove unused dec
fixup: add Uint8Array check in test
fixup: don't throw invalid arg error on `Uint8Array`s

ronag changed the title ~~http2: add type checks for Http2Server.Response.write~~ http: don't throw on Uint8Arrays for http.ServerResponse#write

May 10, 2020

targos pushed a commit that referenced this pull request

May 16, 2020

Don't throw errors on Uint8Arrays and added test for all
valid types.
PR-URL: #33155
Fixes: #33379
Refs: #29829
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Closed

4 tasks

rexagod added a commit to rexagod/node that referenced this pull request

May 20, 2020

Don't throw errors on Uint8Arrays and added test for all
valid types.
Backport-PR-URL: nodejs#33488
PR-URL: nodejs#33155
Fixes: nodejs#33379
Refs: nodejs#29829
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Closed

4 tasks

rexagod added a commit to rexagod/node that referenced this pull request

May 20, 2020

Don't throw errors on Uint8Arrays and added test for all
valid types.
Backport-PR-URL: nodejs#33490
PR-URL: nodejs#33155
Fixes: nodejs#33379
Refs: nodejs#29829
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Closed

32 tasks

codebytere pushed a commit that referenced this pull request

Jun 27, 2020

Don't throw errors on Uint8Arrays and added test for all
valid types.
Backport-PR-URL: #33490
PR-URL: #33155
Fixes: #33379
Refs: #29829
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Merged

codebytere pushed a commit that referenced this pull request

Jun 30, 2020

Don't throw errors on Uint8Arrays and added test for all
valid types.
Backport-PR-URL: #33490
PR-URL: #33155
Fixes: #33379
Refs: #29829
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Aug 18, 2020

Don't throw errors on Uint8Arrays and added test for all
valid types.
Backport-PR-URL: #33488
PR-URL: #33155
Fixes: #33379
Refs: #29829
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Merged

jimmy54 pushed a commit to jimmy54/nodejs-mobile that referenced this pull request

Dec 31, 2025

Don't throw errors on Uint8Arrays and added test for all
valid types.
Backport-PR-URL: nodejs/node#33488
PR-URL: nodejs/node#33155
Fixes: nodejs/node#33379
Refs: nodejs/node#29829
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>