ronag · GitHub

@ronag added stream

Issues and PRs related to the stream subsystem.

semver-major

PRs that contain breaking changes and should be released in the next major version.

blocked

PRs that are blocked by other issues or PRs.

labels

Mar 9, 2020

@ronag

@ronag

vweevers

@ronag

@ronag ronag changed the title stream: make pipeline try to wait for 'close' stream: make finished try to wait for 'close'

Mar 10, 2020

@ronag

ronag

mcollina

ronag referenced this pull request

Mar 10, 2020
If the last stream in a pipeline is still usable/readable
don't destroy it to allow further composition.
Fixes: #32105
PR-URL: #32110
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@ronag

Closed

2 tasks

@ronag

@ronag ronag added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

and removed blocked

PRs that are blocked by other issues or PRs.

labels

Mar 13, 2020

@addaleax addaleax removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 13, 2020

@ronag

jasnell

@ronag

@ronag

Pipeline uses eos which will invoke the callback
on 'finish' and 'end' before all streams have been
fully destroyed.
Fixes: nodejs#32032

@ronag

@ronag

mcollina

addaleax

addaleax pushed a commit that referenced this pull request

Mar 27, 2020
Pipeline uses eos which will invoke the callback
on 'finish' and 'end' before all streams have been
fully destroyed.
Fixes: #32032
PR-URL: #32158
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Merged

@ronag ronag mentioned this pull request

Apr 20, 2020

Closed

4 tasks

Closed

@ronag ronag mentioned this pull request

Apr 25, 2020

Closed

4 tasks

Merged

@wh0 wh0 mentioned this pull request

Jan 22, 2024

Closed

Read the original on github.com ↗