added the fs

Issues and PRs related to the fs subsystem / file system.

label

Jan 18, 2020

PRs that contain breaking changes and should be released in the next major version.

label

Jan 18, 2020

Previously due to compat reasons 'close' was only emitted if no 'error'.
This removes the compat behavior in order to properly follow expected
streams behavior.

BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jan 20, 2020

Trott pushed a commit that referenced this pull request

Jan 21, 2020

Previously due to compat reasons 'close' was only emitted if no 'error'.
This removes the compat behavior in order to properly follow expected
streams behavior.
PR-URL: #31408
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>

Merged

Closed

Merged

4 tasks

Trott pushed a commit to kevinoid/node that referenced this pull request

Jan 2, 2021

The default for the `emitClose` option was changed from `false` to
`true` by nodejs#31408 which landed in  f0d2df4  for v14.0.0.
This commit updates the fs doc to match the current behavior.
Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
PR-URL: nodejs#36653
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>

danielleadams pushed a commit that referenced this pull request

Jan 12, 2021

The default for the `emitClose` option was changed from `false` to
`true` by #31408 which landed in  f0d2df4  for v14.0.0.
This commit updates the fs doc to match the current behavior.
Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
PR-URL: #36653
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>

targos pushed a commit that referenced this pull request

Aug 8, 2021

The default for the `emitClose` option was changed from `false` to
`true` by #31408 which landed in  f0d2df4  for v14.0.0.
This commit updates the fs doc to match the current behavior.
Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
PR-URL: #36653
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>

BethGriggs pushed a commit that referenced this pull request

Aug 12, 2021

The default for the `emitClose` option was changed from `false` to
`true` by #31408 which landed in  f0d2df4  for v14.0.0.
This commit updates the fs doc to match the current behavior.
Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
PR-URL: #36653
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>

Open

4 tasks