This makes all the parameters of the `fs.read` function, except
for `fd` and the callback(when not using as a promise) optional.
They will default to sensible defaults
fixes nodejs#31237

added the fs

Issues and PRs related to the fs subsystem / file system.

label

Jan 17, 2020

BridgeAR added the wip

Issues and PRs that are still a work in progress.

label

Jan 20, 2020

ronag removed the wip

Issues and PRs that are still a work in progress.

label

Jan 27, 2020

now using the options object instead of making all things optional

Co-Authored-By: Richard Lau <riclau@uk.ibm.com>

Co-Authored-By: Richard Lau <riclau@uk.ibm.com>

ronag added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 10, 2020

addaleax added the semver-minor

PRs that contain new features and should be released in the next minor version.

label

Mar 11, 2020

addaleax pushed a commit that referenced this pull request

Mar 11, 2020

This makes all the parameters of the `fs.read` function, except
for `fd` and the callback(when not using as a promise) optional.
They will default to sensible defaults.
Fixes: #31237
PR-URL: #31402
Reviewed-By: Robert Nagy <ronagy@icloud.com>

MylesBorins pushed a commit that referenced this pull request

Mar 11, 2020

This makes all the parameters of the `fs.read` function, except
for `fd` and the callback(when not using as a promise) optional.
They will default to sensible defaults.
Fixes: #31237
PR-URL: #31402
Reviewed-By: Robert Nagy <ronagy@icloud.com>

Merged

Closed

4 tasks

Closed

3 tasks

targos removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 25, 2020

targos pushed a commit to targos/node that referenced this pull request

Apr 25, 2020

This makes all the parameters of the `fs.read` function, except
for `fd` and the callback(when not using as a promise) optional.
They will default to sensible defaults.
Fixes: nodejs#31237
PR-URL: nodejs#31402
Reviewed-By: Robert Nagy <ronagy@icloud.com>

targos pushed a commit that referenced this pull request

Apr 28, 2020

This makes all the parameters of the `fs.read` function, except
for `fd` and the callback(when not using as a promise) optional.
They will default to sensible defaults.
Fixes: #31237
PR-URL: #31402
Reviewed-By: Robert Nagy <ronagy@icloud.com>

Merged